-
Notifications
You must be signed in to change notification settings - Fork 4.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fbprophet was installed using the legacy 'setup.py install' method #1683
Comments
Thanks for the heads up, that will be extremely obnoxious if they do end up pushing that change because of the long discussion in #401 about needing the build dependencies before building the wheel is a success. Pip install will always be supported, we just may in the future have to specify that all of the dependencies have to be separately pip-installed first. |
That is fine but honestly, this needs some serious TLC. Pip doesn't install
pystan dependencies properly in windows and I am sure they would love any
support but this is on fbprophet across all distros. I wasn't sure if the
fbprophet team was aware of this particular issue.
…On Mon, Sep 21, 2020, 4:28 PM Ben Letham ***@***.***> wrote:
Thanks for the heads up, that will be extremely obnoxious if they do end
up pushing that change because of the long discussion in #401
<#401> about needing the build
dependencies before building the wheel is a success. Pip install will
always be supported, we just may in the future have to specify that all of
the dependencies have to be separately pip-installed first.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#1683 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAC5B4V4LHXR6TGBVQ7ETKDSG6ZQLANCNFSM4RUTNU4Q>
.
|
We weren't, so thanks for the heads up. I spent a whole bunch of effort in #401 trying to set up a pyproject.toml to build the build dependencies prior to the trying to build the wheel and ultimately was not successful as described there. I guess we'll be forced to revisit this. |
have you tried upgrading pip first? That solved the issue for me, unexpectedly. |
Pip just got a massive update. I believe that this doesn't work but it does
build the wheel, which is fine. I can check the logs again to see if there
are pip warnings. It is also possible that pip just doesn't report the
issue if it can build the wheel.
Installing on windows still has issues due to pystan and their lack of
support for msvc but that isn't really fbprophet's problem.
Thanks for keeping this up,
Ben
…On Fri, Feb 5, 2021, 3:25 PM Peter Cotton ***@***.***> wrote:
have you tried upgrading pip first? That solved the issue for me,
unexpectedly.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#1683 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAC5B4VHG6RWRBEMGMEAW33S5RH3BANCNFSM4RUTNU4Q>
.
|
Hey, I had this problem also but i've managed to make it work with the following workaround. Before installing fbprophet you have to install pystan. However if you will install like this -> pip install pystan it will fail at building fbprophet because it will grab version 2.19.. that is not compatible with GCC version. Solution: pip install pystan==2.18.0.0 pip install fbprophet |
I'm going to close this to divert discussion on the |
Hello all,
I get this warning and have for a few months now:
DEPRECATION: fbprophet was installed using the legacy 'setup.py install' method, because a wheel could not be built for it. pip 21.0 will remove support for this functionality. A possible replacement is to fix the wheel build issue reported above. You can find discussion regarding this at pypa/pip#8368.
Is this going to get fixed? I would really like it if facebook maintained their package such that it worked with pip.
The text was updated successfully, but these errors were encountered: