Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue with the unit tests originally failing is that
cibuildwheel
will run the unit tests from the{package}
directory, which in this case isprophet/python
. This means thatpkg_resources.resource_filename
will look first in the localprophet/python/prophet/stan_model/
directory since the current directory is first insys.path
. You can sanity-check this logic by pip installing one of the wheels, cd-ing intoprophet/python
and running the unit tests. That should fail provided you don't have any compiled models inprophet/stan_model
.The solution I found was to run the unit tests from the package directory with
pytest --pyargs prophet
. I aslo added some cmdtanpy-backend unit tests to sanity check that.You can see the unit tests passing on my for here