Fix build/test with new location of gmock/gtest #114
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
tedjp
referenced
this pull request
in facebook/wangle
Sep 1, 2016
Summary: Fixes build since googlecode.com stopped hosting projects & GMock was absorbed into GoogleTest. Uses GoogleTest Git repo on GitHub rather than a release tarball/zip. Fixes #59. Closes #60 Reviewed By: mzlee, lukenels Differential Revision: D3795642 Pulled By: anirudhvr fbshipit-source-id: 3cd26b73b4588ffd6bbabfdfca497fd078bfaf4d
|
I'm redoing this using deps.sh to install googletest. |
dgrnbrg-meta
added a commit
to dgrnbrg-meta/proxygen
that referenced
this pull request
Mar 11, 2022
Summary: X-link: facebook/fboss#114 X-link: facebook/fb303#27 When using getdeps inside of a container, Python's urllib isn't able to download from dewey lfs (see this post for details https://fb.workplace.com/groups/systemd.and.friends/permalink/2747692278870647/). This allows for getdeps to use `libcurl` to fetch dependencies, which allows for a getdeps build to work inside the container environment. Reviewed By: mackorone Differential Revision: D34696330 fbshipit-source-id: 357adaf89e70dcce5cc817378a728cc898f39d3c
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GTest is no longer available from googlecode.com. Changed to use the repo from github.
Might not be an ideal way to load the dependency (I suppose I should add it to deps.sh instead) but it works.
Fixes #112.