-
Notifications
You must be signed in to change notification settings - Fork 434
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[pysa][MLH] Hide warnings about high number of overrides #870
Comments
facebook-github-bot
pushed a commit
that referenced
this issue
Jun 18, 2024
Summary: #870 This pull request addresses the issue of warnings related to classes with a high number of overrides in Pysa. It includes the following changes: **Update Override Warning Messages:** Enhanced the warning messages for classes with many overrides to include a suggestion to use the maximum_overrides_to_analyze option. Added a link to the relevant documentation for further guidance. **Configuration Updates:** Added the maximum_overrides_to_analyze option to the taint.config files for different exercises to improve analysis performance and reduce warning messages. **Please provide any feedback as comments for this pull request. I will then apply the feedback and update the code. ** Pull Request resolved: #878 Reviewed By: tianhan0 Differential Revision: D58673147 Pulled By: arthaud fbshipit-source-id: 364a5ec6865c737562906cda6d164120e8698b05
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
When going through the pysa tutorial, users currently get these warnings:
This is because classes with a lot of overrides can lead to slow down of the analysis, since Pysa needs to analyze each override.
To avoid this, we usually set the "maximum_overrides_to_analyze" option: https://pyre-check.org/docs/pysa-advanced/#ignoring-overrides
Anyway, this can be pretty confusing to a new user. Here is what we should do:
pyre init_pysa
.The text was updated successfully, but these errors were encountered: