Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Installation of pyre not working due to unused requirement #902

Open
frederiksteiner opened this issue Jul 29, 2024 · 2 comments
Open

Installation of pyre not working due to unused requirement #902

frederiksteiner opened this issue Jul 29, 2024 · 2 comments

Comments

@frederiksteiner
Copy link

frederiksteiner commented Jul 29, 2024

Pyre Bug

Bug description
The installation of pyre fails when using the newest setuptools version. See also here BUG

The reason being that in the requirements.txt is an unused package (intervalltree) which uses removed stuff in the setup.py
on this line.

Expected behavior

Installation properly working

Since the packages is unused, the easiest would be to just remove it from the requirements.txt.
All our CI/CD pipelines are now not working since we are using pyre-check in them.

facebook-github-bot pushed a commit that referenced this issue Jul 29, 2024
Summary:
**Pre-submission checklist**
- [ x] I've ran the linters locally and fixed lint errors related to the files I modified in this PR. You can install the linters by running `pip install -r requirements-dev.txt && pre-commit install`
- [x ] `pre-commit run`

the library intervaltree seems to be not anymore used in the codebase but still defined as a dependency currently the latest version is broken chaimleib/intervaltree#138

solves #902

Pull Request resolved: #901

Reviewed By: stroxler

Differential Revision: D60394186

Pulled By: samwgoldman

fbshipit-source-id: b6fd3b004437b5bd4283cbf87891cb454856d2e2
@nazimisik
Copy link

fix is merged, we need a new release for changes to take effect

@nazimisik
Copy link

setuptools newest version also helps, no need to wait for the new release now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants