-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Inspected elements within iframes are highlighted incorrectly #443
Comments
Happy to take a fix for this. Would you like to submit one? |
I could tackle it this weekend. Could you point me in the right direction? I'm not at all familiar with the devtools codebase, but would love to learn more. |
I don't know it that well either. I would start with looking at the plain shell and reproducing the issue in it. I'm also not sure if this is even a DevTools issue at all, or just a Chrome issue. I'm not sure how highlighting is implemented. |
Chrome's inspector highlights elements in iframes correctly, and the coloring is slightly different when highlighting in the React Devtools, so it's probably reimplemented. I'll start from there. Thanks |
You'll likely want to hunt for |
I have opened a PR that fixes this issue. If you could review it, I would appreciate it. |
If you hover over an element that lives within an iframe whose position is not the upper-left corner of the parent page, then the blue/green/orange highlight that is drawn over that element to indicate which you are hovering over is not drawn in the right location (iframe offset not accounted for).
Here I am hovering over the "Hello" button:
Here's a link to the page where the screenshot was taken
The text was updated successfully, but these errors were encountered: