This repository has been archived by the owner on Jun 26, 2020. It is now read-only.
Resolve defaultProps for lazy etc #1218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaearon
commented
Nov 7, 2018
| typeof fiber.elementType !== undefined && | ||
| fiber.type !== fiber.elementType | ||
| ) { | ||
| props = resolveDefaultProps(fiber.type, props); |
There was a problem hiding this comment.
I could've put this into a more specific place, like Function + Class + ForwardRef + Memo or whichever ones support it. But I found this easier to read. The only way you could have a false positive here is if somebody assigned defaultProps to e.g. a context consumer. I think that's unlikely enough that it would be fine for DevTools to mistakingly resolve them for a type that doesn't support them — to keep the code readable.
There was a problem hiding this comment.
This seems safe. I think any time fiber.type !== fiber.elementType, it's a lazy component.
bvaughn
approved these changes
Nov 7, 2018
| <LazyWithDefaultProps greeting="Hello" /> | ||
| </React.Suspense> | ||
| </Feature> | ||
| ); |
| typeof fiber.elementType !== undefined && | ||
| fiber.type !== fiber.elementType | ||
| ) { | ||
| props = resolveDefaultProps(fiber.type, props); |
There was a problem hiding this comment.
This seems safe. I think any time fiber.type !== fiber.elementType, it's a lazy component.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to facebook/react#13902.
If
fiber.elementTypeexists and differs fromfiber.type, we need to respect thedefaultPropsdefined on thefiber.type. Such default props wouldn't be kept infiber.memoizedProps. This is why in the React code we also callresolveDefaultProps()in those cases.I added a regression case to demonstrate it. It should display
<FooWithDefaultProps greeting="Hello" name="World" />. In master, it is missingname="World"(that’s the issue I am fixing).