Skip to content

Disable Heap Profiler and legacy JS Profiler for rn_fusebox #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
huntie merged 1 commit into from
Apr 2, 2024
Merged

Disable Heap Profiler and legacy JS Profiler for rn_fusebox #35

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions front_end/core/root/Runtime.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -310,6 +310,7 @@ export enum ExperimentName {
DISABLE_COLOR_FORMAT_SETTING = 'disableColorFormatSetting',
TIMELINE_AS_CONSOLE_PROFILE_RESULT_PANEL = 'timelineAsConsoleProfileResultPanel',
OUTERMOST_TARGET_SELECTOR = 'outermostTargetSelector',
JS_HEAP_PROFILER_ENABLE = 'jsHeapProfilerEnable',
JS_PROFILER_TEMP_ENABLE = 'jsProfilerTemporarilyEnable',
HIGHLIGHT_ERRORS_ELEMENTS_PANEL = 'highlightErrorsElementsPanel',
SET_ALL_BREAKPOINTS_EAGERLY = 'setAllBreakpointsEagerly',
Expand Down
10 changes: 8 additions & 2 deletions front_end/entrypoints/rn_fusebox/rn_fusebox.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,14 +35,20 @@ SDK.TargetManager.TargetManager.instance().addModelListener(
() => Host.rnPerfMetrics.debuggerReadyToPause(),
);

// Legacy JavaScript Profiler - we support this until Hermes can support the
// modern Performance panel.
// Legacy JavaScript Profiler - disabled until we have complete support.
Root.Runtime.experiments.register(
Root.Runtime.ExperimentName.JS_PROFILER_TEMP_ENABLE,
'Enable JavaScript Profiler (legacy)',
/* unstable */ false,
);

// Heap Profiler (Memory panel) - disabled until we have complete support.
Root.Runtime.experiments.register(
Root.Runtime.ExperimentName.JS_HEAP_PROFILER_ENABLE,
'Enable Heap Profiler',
/* unstable */ false,
);

Root.Runtime.experiments.register(
Root.Runtime.ExperimentName.REACT_NATIVE_SPECIFIC_UI,
'Show React Native-specific UI',
Expand Down
8 changes: 8 additions & 0 deletions front_end/entrypoints/rn_inspector/rn_inspector.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,13 @@ Root.Runtime.experiments.register(
/* unstable */ false,
);

// Heap Profiler (Memory panel) - supported, but disabled in rn_fusebox.
Root.Runtime.experiments.register(
Root.Runtime.ExperimentName.JS_HEAP_PROFILER_ENABLE,
'Enable Heap Profiler',
/* unstable */ false,
);

Root.Runtime.experiments.register(
Root.Runtime.ExperimentName.REACT_NATIVE_SPECIFIC_UI,
'Show React Native-specific UI',
Expand All @@ -37,6 +44,7 @@ Root.Runtime.experiments.register(
);

Root.Runtime.experiments.enableExperimentsByDefault([
Root.Runtime.ExperimentName.JS_HEAP_PROFILER_ENABLE,
Root.Runtime.ExperimentName.JS_PROFILER_TEMP_ENABLE,
Root.Runtime.ExperimentName.REACT_NATIVE_SPECIFIC_UI,
]);
Expand Down
1 change: 1 addition & 0 deletions front_end/panels/profiler/profiler-meta.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,7 @@ UI.ViewManager.registerViewExtension({
const Profiler = await loadProfilerModule();
return Profiler.HeapProfilerPanel.HeapProfilerPanel.instance();
},
experiment: Root.Runtime.ExperimentName.JS_HEAP_PROFILER_ENABLE,
});

UI.ViewManager.registerViewExtension({
Expand Down