Disable Heap Profiler and legacy JS Profiler for rn_fusebox #35
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Note
Depends on #34. Please review the latest stacked commit.
Disables the Heap Profiler and legacy JS Profiler for the
rn_fuseboxentry point, since we are currently working with Hermes to patch full support underCDPAgent. These remain enabled inrn_inspector.JS_PROFILER_TEMP_ENABLEexperiment forrn_fusebox.JS_HEAP_PROFILER_ENABLEexperiment and attach toheap_profilerpanel, enable forrn_inspector(disabled forrn_fusebox).Test plan
Screen.Recording.2024-03-28.at.11.45.14.mov
Navigate to
rn_inspector.html✅ Renders, no unexpected console errors
✅ "Memory" and "Profiler" panels visible
Navigate to
rn_fusebox.html✅ Renders, no unexpected console errors
✅ "Memory" and "Profiler" panels unavailable
Upstreaming plan
devtools-frontendrepo. I've reviewed the contribution guide.