Skip to content

Conversation

@huntie
Copy link
Member

@huntie huntie commented Mar 28, 2024

Summary

Note

Depends on #34. Please review the latest stacked commit.

Disables the Heap Profiler and legacy JS Profiler for the rn_fusebox entry point, since we are currently working with Hermes to patch full support under CDPAgent. These remain enabled in rn_inspector.

  • Disable JS_PROFILER_TEMP_ENABLE experiment for rn_fusebox.
  • Register new JS_HEAP_PROFILER_ENABLE experiment and attach to heap_profiler panel, enable for rn_inspector (disabled for rn_fusebox).

Test plan

Screen.Recording.2024-03-28.at.11.45.14.mov

Navigate to rn_inspector.html
✅ Renders, no unexpected console errors
✅ "Memory" and "Profiler" panels visible

Navigate to rn_fusebox.html
✅ Renders, no unexpected console errors
✅ "Memory" and "Profiler" panels unavailable

Upstreaming plan

  • This commit should be sent as a patch to the upstream devtools-frontend repo. I've reviewed the contribution guide.
  • This commit is React Native-specific and cannot be upstreamed.

@EdmondChuiHW
Copy link

LGTM pending merge conflicts in #34.

Looking forward to us shipping the modern performance panel!

@huntie huntie force-pushed the fusebox-entry-point-2 branch from d49b25f to 17b3831 Compare April 2, 2024 13:25
@huntie huntie merged commit 3c57538 into facebook:main Apr 2, 2024
@huntie huntie deleted the fusebox-entry-point-2 branch April 2, 2024 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants