Create FB-only react_devtools_placeholder panel #36
Conversation
huntie
force-pushed
the
fusebox-entry-point-3
branch
from
6e35be3 to
94d11da
Compare
| const ReactDevToolsPlaceholder = await loadReactDevToolsPlaceholderModule(); | ||
| return ReactDevToolsPlaceholder.ReactDevToolsPlaceholder.ReactDevToolsPlaceholderImpl.instance(); | ||
| }, | ||
| experiment: Root.Runtime.ExperimentName.REACT_DEVTOOLS_PLACEHOLDER_PANEL_ENABLE, |
There was a problem hiding this comment.
Can we actually hide this panel / placeholder if ENABLE_REACT_DEVTOOLS_PANEL flag is enabled? This was added in eba41f4
Maybe change logic a bit in a way that if flag is not enabled -> render placeholder. Otherwise, we may end up in a state, when flag is enabled and we render 2 panels: one is placholder and the other is experimental React DevTools panel.
There was a problem hiding this comment.
if flag is not enabled
I'd love to, but can't find any pattern to invert an experiment check in this way in the codebase 😐. What we will have instead is one configuration point where it should be clear we'll disable one experiment over the other.
Root.Runtime.experiments.enableExperimentsByDefault([
Root.Runtime.ExperimentName.REACT_NATIVE_SPECIFIC_UI,
Root.Runtime.ExperimentName.REACT_DEVTOOLS_PLACEHOLDER_PANEL_ENABLE,
]);
There was a problem hiding this comment.
Bit surprised CDT doesn't have the convention of "disabled experiment". In that case, sounds like it would it be simpler to
- remove the existing experiment field from RDT view registration
- modify the existing RDT view registration to load this placeholder based on the existing experiment value.
Depending on where we check the experiment, we can mark the RDT experiment registration as "restart required" too.
That way we have a single deterministic experiment and always have the RDT panel visible (goal of this PR).
There was a problem hiding this comment.
We could do this, but I don't think the juice is worth the squeeze, as we'll remove this placeholder soon enough. Main blocker is the RDT panel hasn't landed yet.
There was a problem hiding this comment.
Discussed offline with @hoxyq — will remove my experiment flag and enable by default. Ruslan will build on top of this to use this panel as the RDT panel.
huntie
force-pushed
the
fusebox-entry-point-3
branch
from
94d11da to
fe5f2a7
Compare
| >npx react-devtools</code | ||
| > | ||
| </div> | ||
| <a |
There was a problem hiding this comment.
I don't think this fburl quite makes sense considering that we launch CDT in a Chrome guest profile.
5 participants
Summary
Note
Depends on #34 ✅ and #35 ✅. Please review the latest stacked commit.
Adds an FB-only
react_devtools_placeholderpanel and enables in thern_fuseboxentry point. This panel is intended to be temporary, until we internally launch the React DevTools feature.Test plan
Upstreaming plan
devtools-frontendrepo. I've reviewed the contribution guide.