Skip to content

Conversation

@hoxyq
Copy link

@hoxyq hoxyq commented Apr 8, 2024

Summary

Instead of updating the template for every entrypoint, we now will be updating the title in the build script. We keep a pre-defined dictionary of all rn-specific entrypoints.

Naming DevTools (React Fusebox ⚡) is open for discussion, might be not the best one.
UPD: renamed to React Native DevTools (React Fusebox ⚡).

Test plan

Manually inspecting rn_fusebox.html and rn_inspector.html.

Upstreaming plan

  • This commit should be sent as a patch to the upstream devtools-frontend repo. I've reviewed the contribution guide.
  • This commit is React Native-specific and cannot be upstreamed.

@hoxyq hoxyq requested a review from motiz88 April 8, 2024 13:48
@hoxyq hoxyq marked this pull request as ready for review April 8, 2024 13:50
@motiz88
Copy link

motiz88 commented Apr 8, 2024

I'm OK with this (though specifying the name as part of each entrypoint, somehow, would be nicer).

Re: Naming - #36 makes it viable to go with React Native DevTools (Fusebox ⚡)

@hoxyq
Copy link
Author

hoxyq commented Apr 8, 2024

rn_fusebox.html:
Screenshot 2024-04-08 at 16 27 48

rn_inspector.html:
Screenshot 2024-04-08 at 14 52 27

@hoxyq hoxyq force-pushed the fusebox/add-codename-to-entrypoint-title branch from 3f3bd59 to c824c4a Compare April 8, 2024 13:54
@hoxyq
Copy link
Author

hoxyq commented Apr 8, 2024

(though specifying the name as part of each entrypoint, somehow, would be nicer)

I don't think there is a way for this currently, looks like all html templates for entrypoints are generated based on directories inside front_end/entrypoints and ninja configs:
https://github.com/facebookexperimental/rn-chrome-devtools-frontend/blob/9a23d4c7c4c2d1a3d9e913af38d6965f474c4284/front_end/BUILD.gn#L105-L140

@hoxyq hoxyq merged commit b0a76fa into facebook:main Apr 8, 2024
@hoxyq hoxyq deleted the fusebox/add-codename-to-entrypoint-title branch April 8, 2024 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants