-
Notifications
You must be signed in to change notification settings - Fork 22
Create forked rn_fusebox entry point #34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary: Context: facebook/react-native-devtools-frontend#34. Changelog: [Internal] Differential Revision: D55474522
…43688) Summary: Context: facebook/react-native-devtools-frontend#34. Changelog: [Internal] Differential Revision: D55474522
…43688) Summary: Context: facebook/react-native-devtools-frontend#34. Changelog: [Internal] Differential Revision: D55474522
Summary: Context: facebook/react-native-devtools-frontend#34. Changelog: [Internal] Differential Revision: D55474521
…acebook#43688) Summary: Context: facebook/react-native-devtools-frontend#34. Changelog: [Internal] Differential Revision: D55474522
…ets (facebook#43689) Summary: Context: facebook/react-native-devtools-frontend#34. Changelog: [Internal] Differential Revision: D55474521
EdmondChuiHW
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Small merge conflict with #33 but should be trivial.
Non-blocking: One thing it could be useful for us is *-meta.ts file/:meta build pattern. CDT convention seems to do setups there and code sharing. That way we can have the common code, e.g. experiment setup code, in the *-meta.ts file. Then the fusebox and rn_insepector entry points will be strictly distinct.
Note for the future: we can also add a response from FuseboxClient.setClientMetadata, so we can redirect/warn people in the UI if they somehow ended up in the Fusebox entrypoint without a supported target
2d99123 to
ceb4140
Compare
Makes sense if we needed to maintain both entry points for the long term. In this case, the plan is to effectively freeze development on the old entry point and only touch |
Summary: Pull Request resolved: #43688 Context: facebook/react-native-devtools-frontend#34. Changelog: [Internal] Reviewed By: EdmondChuiHW Differential Revision: D55474522 fbshipit-source-id: 4f514dba228bfa4df41a0eb9687f2525cc32b2d7
…ets (#43689) Summary: Pull Request resolved: #43689 Context: facebook/react-native-devtools-frontend#34. Changelog: [Internal] Reviewed By: motiz88 Differential Revision: D55474521 fbshipit-source-id: 9756fe29adcbdda686af24c1a65073720cba4b53
Summary
Adds a new
rn_fuseboxDevTools entry point, forked fromrn_inspector. This entry point is designed to work with all features of the next-gen debugging stack (codename: React Fusebox ⚡).Differences between entry points:
rn_inspector.html— The current Experimental Debugger experience used in open source (RN + Expo), compatible with HermesCDPHandler.rn_fusebox.tsinstead:Host.RNPerfMetricsENABLE_REACT_DEVTOOLS_PANELexperimentFuseboxClientMetadataModelrn_fusebox.htmlrn_inspectorprior to this PR.Ideally, we will de-fork at some point in future and return to one
rn_inspector.htmlentry point.Note
This change should not be synced to React Native until we've configured the launch flow to conditionally select
rn_fusebox.html.Test plan
New
rn_fusebox.htmlentry point✅ Renders, no unexpected console errors
rn_inspector.htmlentry point unchanged✅ Renders, no unexpected console errors
Upstreaming plan
devtools-frontendrepo. I've reviewed the contribution guide.