-
Notifications
You must be signed in to change notification settings - Fork 22
Add "[FB-only] Send feedback" button #33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
huntie
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, pending blocking feedback on the prior two PRs.
Also, I wonder if we can apply any custom styling on this button — e.g. giving it a fully red background colour (or just for the region behind the bug icon). It's worth making it stand out a little more — especially as it's on the welcome panel only(?) 🙂.
|
The view is currently provided by CDT built-ins, but we can definitely follow-up with some custom styling! (subject to timeboxing 😜) Visibility-wise, this button is available across all panels; it lives in the same toolbar location as the built-in settings button. In fact, it's an option in the "command prompt" (⌘ + P) too since it's an "action" in CDT. I thought about labelling this as |
34fe77a to
9663a9b
Compare


Summary
Minor tweaks to help internal dogfooders send feedback.
Stack
doclinkto experiment #31feedbackLinkto experiment #32Test plan
With
globalThis.FB_ONLY__reactNativeFeedbackLink = 'https://example.com':Clicking the button opens a new window to
https://example.com.Upstreaming plan
devtools-frontendrepo. I've reviewed the contribution guide.