Skip to content

Conversation

@EdmondChuiHW
Copy link

@EdmondChuiHW EdmondChuiHW commented Mar 26, 2024

Summary

Minor tweaks to help internal dogfooders send feedback.

  • add "[FB-only] Send feedback" button to the toolbar

Stack

Test plan

With globalThis.FB_ONLY__reactNativeFeedbackLink = 'https://example.com':

image

Clicking the button opens a new window to https://example.com.

Upstreaming plan

  • This commit should be sent as a patch to the upstream devtools-frontend repo. I've reviewed the contribution guide.
  • This commit is React Native-specific and cannot be upstreamed.

@EdmondChuiHW EdmondChuiHW marked this pull request as ready for review March 26, 2024 03:10
@EdmondChuiHW EdmondChuiHW changed the title Feedback button Add feedback button Mar 26, 2024
@EdmondChuiHW EdmondChuiHW changed the title Add feedback button Add "send feedback" button Mar 26, 2024
Copy link
Member

@huntie huntie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, pending blocking feedback on the prior two PRs.

Also, I wonder if we can apply any custom styling on this button — e.g. giving it a fully red background colour (or just for the region behind the bug icon). It's worth making it stand out a little more — especially as it's on the welcome panel only(?) 🙂.

@EdmondChuiHW
Copy link
Author

The view is currently provided by CDT built-ins, but we can definitely follow-up with some custom styling! (subject to timeboxing 😜)

Visibility-wise, this button is available across all panels; it lives in the same toolbar location as the built-in settings button. In fact, it's an option in the "command prompt" (⌘ + P) too since it's an "action" in CDT.

I thought about labelling this as [FB-only] Send feedback so we can adjust that too to bring more visibility. Discussion in prev PR: #32 (comment)

@EdmondChuiHW
Copy link
Author

Discussed offline.
Updating global var name and label with the [FB-only] prefix.

image image

@EdmondChuiHW EdmondChuiHW requested a review from huntie March 27, 2024 15:16
@EdmondChuiHW EdmondChuiHW changed the title Add "send feedback" button Add "[FB-only] Send feedback" button Mar 27, 2024
@EdmondChuiHW EdmondChuiHW merged commit 0d6a536 into facebook:main Mar 28, 2024
@EdmondChuiHW EdmondChuiHW deleted the feedback-button branch May 29, 2024 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants