refactor: add actual stub view for React DevTools panel #17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huntie
approved these changes
Mar 13, 2024
2 tasks
hoxyq
force-pushed
the
react-devtools/add-panel-stub
branch
from
2532dfe to
ef9f710
Compare
hoxyq
commented
Apr 9, 2024
Comment on lines
+44
to
+49
| if (Root.Runtime.Runtime.isDescriptorEnabled({ | ||
| experiment: Root.Runtime.ExperimentName.ENABLE_REACT_DEVTOOLS_PANEL, | ||
| condition: null, | ||
| })) { | ||
| return Module.ReactDevToolsView.ReactDevToolsViewImpl.instance(); | ||
| } |
hoxyq
changed the title
hoxyq
changed the title
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Stacked on #15. Review only the last commit at the top.
panels/react_devtools_placeholder->panels/react_devtoolsEnable React DevToolsexperiment is enabled, the new custom view should be rendered, which is currently empty, but will soon host React DevTools frontend.Test plan
Without feature flag enabled in
Experiments:With feature flag enabled in
Experiments:Upstreaming plan
devtools-frontendrepo. I've reviewed the contribution guide.