feat: add ReactDevToolsModel #19
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
2 tasks
hoxyq
force-pushed
the
react-devtools/add-react-devtools-model
branch
from
c501a99 to
fb7003d
Compare
blakef
approved these changes
Apr 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds
ReactDevToolsModel, which will provide an interface toReactDevToolsViewfor subscribing to / sending RDT-related messages.ReactDevToolsModelis usingReactDevToolsBindingsModelfor it, which was added in #15, specifying a separatereact-devtoolsdomain/namespace.Test plan
Once the React DevTools panel is opened, the global binding is automatically created:
Upstreaming plan
devtools-frontendrepo. I've reviewed the contribution guide.