Skip to content

Conversation

@motiz88
Copy link

@motiz88 motiz88 commented Mar 20, 2024

Summary

Followup from #24. We want to not just positively detect the Fusebox client, but detect the use of non-Fusebox clients as well. To this end, we want to guarantee that the Fusebox frontend always sends FuseboxClient.setClientMetadata before (say) Runtime.enable, so that if we receive a Runtime.enable message without a preceding FuseboxClient.setClientMetadata, we know we're dealing with a non-Fusebox client.

As mentioned in a code comment, there's a proper way to express dependencies between frontend models, and we should do that. For now, I want to avoid duplicating the work that @hoxyq is currently doing in the stack of #19 to set up the first RN-specific models. We can follow up on this when those PRs have landed.

Test plan

Tested as part of https://www.internalfb.com/diff/D55122115.

Upstreaming plan

  • This commit should be sent as a patch to the upstream devtools-frontend repo. I've reviewed the contribution guide.
  • This commit is React Native-specific and cannot be upstreamed.

@motiz88 motiz88 marked this pull request as ready for review March 20, 2024 14:51
@motiz88 motiz88 merged commit 0beb10c into facebook:main Mar 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants