Skip to content

Early init FuseboxClientMetadataModel #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
motiz88 merged 1 commit into from
Mar 20, 2024
Merged

Early init FuseboxClientMetadataModel #25

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion front_end/entrypoints/rn_inspector/rn_inspector.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,17 @@ class FuseboxClientMetadataModel extends SDK.SDKModel.SDKModel<void> {

SDK.SDKModel.SDKModel.register(
FuseboxClientMetadataModel,
{capabilities: SDK.Target.Capability.None, autostart: true},
{
capabilities: SDK.Target.Capability.None,
autostart: true,
// Ensure FuseboxClient.setClientMetadata is sent before most other CDP domains
// are initialised. This allows the backend to confidently detect non-Fusebox
// clients by the fact that they send e.g. Runtime.enable without sending any
// Fusebox-specific messages first.
// TODO: Explicitly depend on this model in RuntimeModel and LogModel, and
// remove the `early` and `autostart` flags.
early: true,
},
);

// @ts-ignore Exposed for legacy layout tests
Expand Down