Allow enabling the Performance panel in Fusebox #43
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Note
NOTE: Stacked on #42 - please review only the last commit.
Creates a new RN-specific experiment titled "Enable Performance panel". Outside of the RN entry points, this defaults to true and isn't configurable as an experiment. In Fusebox (only), this new experiment can be enabled in Settings.
The Fusebox backend only has stub support for the Performance panel (facebook/react-native#44004) so this is definitely not ready for widespread use. An experiment flag will help us iterate on Performance support without constantly rebuilding CDT.
Test plan
inspector.htmlhas the Performance panel and doesn't show the experiment in Settings.rn_inspector.htmlhas the legacy Profiler panel and doesn't show the experiment in Settings.rn_fusebox.htmlboots without either Performance or JavaScript Profiler. Either/both can be enabled via Settings.Upstreaming plan
devtools-frontendrepo. I've reviewed the contribution guide.