feat: define react devtools experiment flag #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huntie
approved these changes
Mar 4, 2024
EdmondChuiHW
reviewed
Mar 8, 2024
| import '../../panels/network/network-meta.js'; | ||
| import '../../panels/js_profiler/js_profiler-meta.js'; | ||
| import '../../panels/rn_welcome/rn_welcome-meta.js'; | ||
| import '../../panels/react_devtools/react_devtools-meta.js'; |
There was a problem hiding this comment.
Looks like this file isn't ready yet and the import statement wasn't intended for this PR. It's crashing the RN Inspector landing page so it's remove the line until the file is ready (or add an empty stub file for now)
Author
There was a problem hiding this comment.
Oh, you are right, somehow slipped in this PR, will fix that
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adding
enableReactDevToolsPanelexperiment, which will be used for gating React DevTools panel. Later, this experiment will be enabled based on a query parameter provided by the entity, which launches the Chrome.Test plan
This doesn't introduce any functional changes at the moment, only checking if this experiment appears in the list of experiments, so it can be toggled for manual testing of RDT panel.
Upstreaming plan
devtools-frontendrepo. I've reviewed the contribution guide.