Capture console errors; not just unhandled ones #80
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Initially introduced in #74, unhandled errors and rejected Promises are captured.
Generic
console.errorcalls were omitted due to the existing noisy outputs of unimplemented CDP methods.After discussion with @motiz88 and @hoxyq, we agreed these are still valuable signals on the health of the debugger frontend.
Test plan
Run:
Add this line to
out/Release/args.gn, this enables the minifier:Run:
Check file:
Observe the output follows our intended impl:
Upstreaming plan
devtools-frontendrepo. I've reviewed the contribution guide.