Add dimming to ignore-listed links in stacktrace when logging Error object #99
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
CDT already does the work in assigning the correct CSS class for links that are in the ignore list:
https://github.com/facebookexperimental/rn-chrome-devtools-frontend/blob/a93a780a69a9a9fc4b744ad818f9e620b6091376/front_end/ui/legacy/components/utils/Linkifier.ts#L487
And it's used in various components:
https://github.com/facebookexperimental/rn-chrome-devtools-frontend/blob/a93a780a69a9a9fc4b744ad818f9e620b6091376/front_end/ui/legacy/components/utils/jsUtils.css#L22-L24
https://github.com/facebookexperimental/rn-chrome-devtools-frontend/blob/a93a780a69a9a9fc4b744ad818f9e620b6091376/front_end/panels/application/components/stackTraceRow.css#L30-L32
This PR adds support to the renderer of Error objects.
Test plan
Before
After
Upstreaming plan
devtools-frontendrepo. I've reviewed the contribution guide.