Update running-on-device.md #1312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`NSAllowsArbitraryLoads` was introduced in facebook/react-native#19643 and defaults to `true`. That means that removing `localhost` from `NSExceptionDomains` is not enough anymore, as describe in #1058. Kudos to @Ashoat who tracked down the origin of the issue: #1058 (comment) Closes #1058
|
Deploy preview for react-native ready! Built with commit 86f6b98 https://deploy-preview-1312--react-native.netlify.com Changes to Thank you for your contributions. |
espipj
pushed a commit
to espipj/react-native-website
that referenced
this pull request
Feb 8, 2020
`NSAllowsArbitraryLoads` was introduced in facebook/react-native#19643 and defaults to `true`. That means that removing `localhost` from `NSExceptionDomains` is not enough anymore, as describe in facebook#1058. Kudos to @Ashoat who tracked down the origin of the issue: facebook#1058 (comment) Closes facebook#1058
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NSAllowsArbitraryLoadswas introduced in facebook/react-native#19643 and defaults totrue. That means that removinglocalhostfromNSExceptionDomainsis not enough anymore, as describe in #1058.Kudos to @Ashoat who tracked down the origin of the issue: #1058 (comment)
Closes #1058