Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Android Environment setup #2070

Merged
merged 4 commits into from
Jul 24, 2020
Merged

Conversation

well-ington
Copy link
Contributor

PR regarding issue #1610
Added a quick guide on how to upgrade the project Gradle version to avoid errors when using the lastest version of JDK.
Updated the Android Studio installation guide.

PR regarding issue facebook#1610
Added a quick guide on how to upgrade the project Gradle version to avoid errors when using the lastest version of JDK.
Updated the Android Studio installation guide.
@react-native-bot
Copy link

react-native-bot commented Jul 18, 2020

Deploy preview for react-native ready!

Built with commit 1343f8f

https://deploy-preview-2070--react-native.netlify.app

Changes to docs/ are reflected in the next "master" version.

Thank you for your contributions.

How to ContributeDocumentation Sources

docs/getting-started.md Outdated Show resolved Hide resolved
docs/getting-started.md Outdated Show resolved Hide resolved
docs/getting-started.md Outdated Show resolved Hide resolved
docs/getting-started.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@Simek Simek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check the comments above! 😉

Reverted JDK suggestions to version 8, added '>' before the Gradle upgrade tip, fixed a sentence regarding Android Studio installation, added a tip regarding build tools that have compatibility with Python3 versions.
@well-ington well-ington requested a review from Simek July 22, 2020 20:23
Copy link
Collaborator

@Simek Simek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the great job on the PR and the changes verification! 👍

@Simek Simek merged commit a39b266 into facebook:master Jul 24, 2020
@Simek Simek mentioned this pull request Aug 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Getting Started" doc for React Native CLI > Windows > Android could do with some updating
4 participants