Added workarounds for TextInputs #2203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @EyMaddis! Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
|
Deploy preview for react-native ready! Built with commit b8eddfc https://deploy-preview-2203--react-native.netlify.app Changes to Thank you for your contributions. |
gedeagas
reviewed
Sep 7, 2020
There was a problem hiding this comment.
Thx for the awesome pr @EyMaddis, can you also add this one facebook/react-native#29774? This issue is about Scrollview still scrollable with dpad when scrollEnabled={false}
|
@gedeagas If the fix is known (and the PR seems to be rather certain...), I do not think that we need to include it. |
|
It would be sometimes until the fix is released on react-native, and given the fix require you to have a custom version of react-native with the workaround applied I think adding this note to the known issue section will help users. |
|
@Simek what do you think? |
|
@EyMaddis Thank you for adding the useful tips for TV builds! 👍 @gedeagas It looks like the commit you have mentioned in the DPad scroll issue has bee a part of |
|
@Simek the commit is not working hence there is a new issue report |
Can you link the new issue? Are you sure that reporter was using at least |
|
@Simek it's the same issue here facebook/react-native#29774 The issue here is that after testing it this commit facebook/react-native@00c8b3c does not work. PR is already on the way here facebook/react-native#29906. |
|
@gedeagas The reporter is using |
Simek
approved these changes
Sep 10, 2020
slorber
pushed a commit
to react-native-website-migration/react-native-website
that referenced
this pull request
Oct 9, 2020
* Update introduction.md (facebook#2181) Hooks were introduced in React Native 0.59, not 0.58. * adding snack player instead of images for flexbox (facebook#2171) * adding snack player instead of images for flexbox * chore: revert yarn.lock * minor changes and improvements, prettier run on examples Co-authored-by: Bartosz Kaszubowski <gosimek@gmail.com> * UI & UX Design with InputAccessoryView (facebook#2183) * UI Design with InputAccessoryView * Update inputaccessoryview.md * small tweaks Co-authored-by: Bartosz Kaszubowski <gosimek@gmail.com> * update TextInput example, refs facebook#2187 * add TOC and improve formatting on the Android publishing page * Modernize code examples in the direct manipulation section (facebook#2189) * Modernize code examples in the direct manipulation section. * small code tweaks/fixes + run code through Prettier Co-authored-by: Bartosz Kaszubowski <gosimek@gmail.com> * update Alert API page, include iOS specific functions from deprecated AlertIOS (facebook#2184) Thanks for this one, @Simek! * Update getting-started.md (facebook#2194) Python2 & Python3 are both compatible * fix homepage showcase app list graphical issue (facebook#2185) Co-authored-by: R Nabors <rachelnabors@users.noreply.github.com> * docs: add matrix to transform (facebook#2197) * Bump decompress from 4.2.0 to 4.2.1 in /website (facebook#2200) Bumps [decompress](https://github.com/kevva/decompress) from 4.2.0 to 4.2.1. - [Release notes](https://github.com/kevva/decompress/releases) - [Commits](kevva/decompress@v4.2.0...v4.2.1) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Typo fix (facebook#2202) * fixes facebook#2201, delete duplicated TOC, add note about removal to TabBarIOS pages * docs: update deprecated usage of findNodeHandle in measureLayout (facebook#2199) * docs: update deprecated usage of findNodeHandle in measureLayout * minor text and Snack tweaks, prettier run Co-authored-by: Bartosz Kaszubowski <gosimek@gmail.com> * bump alex and node-fetch, fix new alex warning * typo fix * TextInput: Add `onPressIn` and `onPressOut` docs (facebook#2205) Original summary by @yungsters in [1b994f9](facebook/react-native@b7b0e23): Introduces support for `onPressIn` and `onPressOut` on the `TextInput` component. This makes it possible to add visual feedback when users touch interact with `TextInput` components. * Fix typos (facebook#2204) * link out-of-tree platforms, add macOS platform, unify dashes on homepage (facebook#2186) * link out-of-tree platforms, add macOS, unify dashes on homepage * revert dashes changes * update SectionList page, extract ViewToken, add labels (facebook#2191) * update TextInput press callbacks type, refs facebook#2205 * Added workarounds for TextInputs (facebook#2203) * Added workarounds for TextInputs * provide info on the focus management using <Modal> * small text tweaks Co-authored-by: Bartosz Kaszubowski <gosimek@gmail.com> * update Text page and add types, add LayoutEvent object page (facebook#2209) * Incorrect command (facebook#2207) https://github.com/react-native-community/cli/blob/master/docs/commands.md#run-android `--variant [string]` * Updated ScrollView `disableIntervalMomentum` doc. (facebook#2211) * Remove announcement banner. (facebook#2213) * Docs: Removing `onTextInput` prop from TextInput (facebook#2216) * Removing `onTextInput` prop from TextInput doc. * Removing `onTextInput` prop from TextInput on version 0.62 & 0.63. * Signing not under General for me (facebook#2214) * Update running-on-simulator-ios.md (facebook#2220) We have to specify the generation for the iPhone SE simulator. * [DOC] fixed errata in image doc (facebook#2221) * Add documentation for Hermes sampling profiler (facebook#2159) Co-authored-by: Saphal Patro <31125345+saphal1998@users.noreply.github.com> Co-authored-by: R Nabors <rachelnabors@users.noreply.github.com> Co-authored-by: Saphal Patro <saphal1998@gmail.com> * Adding Android NDK Installation Guide (facebook#2225) * Docs: Integration with android fragment (facebook#2217) Co-authored-by: Sebastien Bailouni <sbailouni@gmail.com> * Add new option to ActionSheetIOS called disabledButtonsIndices (facebook#1898) * Adding configureNext.onAnimationDidFail callback on LayoutAnimation (facebook#2136) Co-authored-by: Christoph Nakazawa <cpojer@fb.com> * Added Coinbase to showcase (facebook#2227) * Added Coinbase to showcase * Add Coinbase icon * 0.63.3 release - update Pressable delay (facebook#2226) * Improved README.md (facebook#2233) * fix typo (facebook#2232) * fix typo fixes typo in "Using Custom Path Aliases with TypeScript" section (configure -> configuring) * sentence rewrite Co-authored-by: Bartosz Kaszubowski <gosimek@gmail.com> * Add Shopify and Tableau to showcase (facebook#2228) * Add Shopify in showcase * Add Shopify icon * Add Tableau to showcase * Add tableau image asset * Update Tableau icon * updated debugging.md (facebook#2241) fixed a typo in unhandled error * Update appregistry.md (facebook#2246) * Update out-of-tree-platforms.md (facebook#2243) * Remove unnecessary python dependency (facebook#2250) Python is not required anymore on windows platform. The only binary addon for react-native project are some deps of `ws`, [which now have prebuilt binary and are optional](https://github.com/websockets/ws#opt-in-for-performance-and-spec-compliance). Tested on a brand new windows 10 image with only node installed, the initiating process goes well. * Update network.md to show android non ssl block (facebook#2245) * Update network.md to show android non ssl block added note for android's android:usesCleartextTraffic flag in manifest file to allow non ssl encrypted networking - to go alongside the existing note for ios. * small text tweaks Co-authored-by: Bartosz Kaszubowski <gosimek@gmail.com> * remove link in native-modules-ios (facebook#2244) Co-authored-by: luism3861 <eduardo_media@fragua.com.mx> * Update textinput.md (facebook#2249) * Update textinput.md This will make it more clear for beginners who are trying to use onBlur to do a final action on their textInput's text value. * formatting, text tweaks Co-authored-by: Bartosz Kaszubowski <gosimek@gmail.com> * revert change to Netlify config due to V2 test merge Co-authored-by: Georgios Kotziabassis <kotziabassis@gmail.com> Co-authored-by: Muhammad Saeed <37156636+Stringsaeed@users.noreply.github.com> Co-authored-by: Bartosz Kaszubowski <gosimek@gmail.com> Co-authored-by: Mojtaba Vandaei <62926492+mojvan@users.noreply.github.com> Co-authored-by: Steven Luscher <steveluscher@users.noreply.github.com> Co-authored-by: Pratik Khandelwal <prkhandelwal@hotmail.com> Co-authored-by: R Nabors <rachelnabors@users.noreply.github.com> Co-authored-by: Jesse Katsumata <jesse.katsumata@gmail.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Joe Bernard <joe@joebernard.com> Co-authored-by: Thibault Malbranche <thibault.malbranche@epitech.eu> Co-authored-by: Luis Miguel Alvarado <luismiguel1730@gmail.com> Co-authored-by: Pramod Kotipalli <p13i@users.noreply.github.com> Co-authored-by: Madd.is <github@madd.is> Co-authored-by: Kirill <laikisounds@gmail.com> Co-authored-by: Ashwin Mothilal <ashwin.mothilal2124@gmail.com> Co-authored-by: Christoph Nakazawa <cpojer@fb.com> Co-authored-by: captDaylight <paul.christophe6@gmail.com> Co-authored-by: ppichier <pierantonio.pichierri@gmail.com> Co-authored-by: Varunendra Pratap Singh <vpsingh016@gmail.com> Co-authored-by: Jessie Anh Nguyen <47696418+jessieAnhNguyen@users.noreply.github.com> Co-authored-by: Saphal Patro <31125345+saphal1998@users.noreply.github.com> Co-authored-by: Saphal Patro <saphal1998@gmail.com> Co-authored-by: Agastya Darma <gedeagas22@gmail.com> Co-authored-by: Steven Martin <stevenisekimartin@gmail.com> Co-authored-by: Sebastien Bailouni <sbailouni@gmail.com> Co-authored-by: Luke Walczak <lukasz.walczak.pwr@gmail.com> Co-authored-by: Jessica Lin <jlin2700@gmail.com> Co-authored-by: Vishal Vishwakarma <56310842+vishalvishw10@users.noreply.github.com> Co-authored-by: Adam Hunter <arhunter@gmail.com> Co-authored-by: Jessica Lin <jplin@fb.com> Co-authored-by: Ashish Shakya <41261918+Ashish1101@users.noreply.github.com> Co-authored-by: Sunny Luo <sunnylqm@gmail.com> Co-authored-by: Alexander Sklar <asklar@microsoft.com> Co-authored-by: s-maurice <51819025+s-maurice@users.noreply.github.com> Co-authored-by: luism3861 <36824170+luism3861@users.noreply.github.com> Co-authored-by: luism3861 <eduardo_media@fragua.com.mx> Co-authored-by: Ralph Maamari <ralphpal@hotmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a bit of info for other people struggling with Android TV.