support high contrast colors #2640
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✔️ Deploy Preview for react-native ready! 🔨 Explore the source changes: 4a39eca 🔍 Inspect the deploy log: https://app.netlify.com/sites/react-native/deploys/60d1b852d1f04200077370b1 😎 Browse the preview: https://deploy-preview-2640--react-native.netlify.app |
Simek
added
🕐 Waiting on PR
Simek
reviewed
Jun 21, 2021
Simek
removed
🕐 Waiting on PR
Simek
approved these changes
Jun 21, 2021
There was a problem hiding this comment.
As you mentioned the feature has landed in 0.65 branch, so this PR is ready to merge to next version now. 🙂
Thank you for posting update to the docs, and working on high contrast color support in the first place. Please fix the comments in the first code block, besides that changes LGTM, great work! 👍
Co-authored-by: Bartosz Kaszubowski <gosimek@gmail.com>
|
Accepted, Thanks @Simek |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update docs to support High Contrast colors, outlined in this PR: facebook/react-native#31651