Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

win/android docs: update node install to use nodejs-lts #2869

Merged
merged 2 commits into from
Dec 6, 2021

Conversation

PaulB-H
Copy link
Contributor

@PaulB-H PaulB-H commented Nov 30, 2021

What:
Updated React Native CLI Quickstart/Windows-Android docs to use the LTS version of node during choco install, and recommended use of LTS in general, similarly to how React docs do the same.

Why:
_getting-started-windows-android.md currently lists the choco install command as:
choco install -y nodejs.install openjdk8
...which will install node.js version 17 (current)

While you will still be able to init an app with the react-native CLI and node.js 17, the command npx react-native run-android will fail due to the same bug affecting facebook/create-react-app#11562

@facebook-github-bot
Copy link

Hi @PaulB-H!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@netlify
Copy link

netlify bot commented Nov 30, 2021

✔️ Deploy Preview for react-native ready!

🔨 Explore the source changes: 5cbe568

🔍 Inspect the deploy log: https://app.netlify.com/sites/react-native/deploys/61a5f88962478500075ea9cd

😎 Browse the preview: https://deploy-preview-2869--react-native.netlify.app

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

Because L in LTS is pronunced like the L sound in Elenor (el) - a vowel sound - we should use an before it instead of a
@yungsters
Copy link
Contributor

Thanks for the contribution!

@yungsters yungsters merged commit 62e2afe into facebook:main Dec 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants