Add TypeScript support in New Architecture/Codegen #3036
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for react-native ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
cipolleschi
reviewed
Mar 29, 2022
Contributor
cipolleschi
left a comment
cipolleschi
left a comment
There was a problem hiding this comment.
Amazing work! 👏 I'm excited because it will help us also in other pieces of doc work we are carrying on.
I left a few suggestions here and there to improve homogeneity of the documentation and clarity, plus a question about TurboModules types.
cortinico
reviewed
Mar 29, 2022
Contributor
cortinico
left a comment
cortinico
left a comment
There was a problem hiding this comment.
Thanks for doing this @charlesbdudley 👍
@Titozzz might have some opinions to share on this as well
cipolleschi
reviewed
Mar 29, 2022
charlesbdudley
commented
Mar 29, 2022
charlesbdudley
changed the title
cortinico
approved these changes
Apr 13, 2022
Contributor
cortinico
left a comment
cortinico
left a comment
There was a problem hiding this comment.
LGTM 👍 Accepting to unblock you
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the documentation to specify that TypeScript spec files are supported, with examples for both TurboModules and Fabric Components