-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace authorImage with authorImageURL #314
Conversation
Oops, something went wrong with this deploy preview. @charpeni can you look at this? |
Ah gotcha, sorry about that. I added |
@amyrlam Docusaurus 1.0.12 has been released! |
dc1201f
to
ed09b1f
Compare
Deploy preview for react-native ready! Built with commit 963a62e https://deploy-preview-314--react-native.netlify.com Changes to Thank you for your contributions. |
d6429eb
to
5fe5002
Compare
👋 Sorry for the confusion before, this is ready for review now. |
Updated Docusaurus to latest 1.0.14 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good. I am going to let @hramos approve and merge it in.
authorImage will be deprecated in a future Docusaurus version
572ed65
to
86a7a61
Compare
86a7a61
to
963a62e
Compare
Thanks for your contribution! |
authorImage was replaced by authorImageURL in facebook#577 authorImage was removed in react-native-website in facebook/react-native-website#314
authorImage was replaced by authorImageURL in facebook#577 authorImage was removed from react-native-website in facebook/react-native-website#314 authorImage was undocumented, so no docs changes
authorImage was replaced by authorImageURL in facebook#577 authorImage was removed from react-native-website in facebook/react-native-website#314 authorImage was undocumented, so no docs changes
authorImage was replaced by authorImageURL in #577 authorImage was removed from react-native-website in facebook/react-native-website#314 authorImage was undocumented, so no docs changes
Follow on to: facebook#314
⬆️ Docusaurus
authorImage
will be deprecated in DocusaurusIncluded format updates generated by Docusaurus, re: format updates, check out https://github.com/facebook/react-native-website/pull/314/files?w=1will address separatelyRelates to: facebook/docusaurus#577 cc @yangshun
No visual change to author image in blog: