-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add onStartReached and sync onEndReached doc #3721
Conversation
✅ Deploy Preview for react-native ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Refs:
Hey @janicduplessis, thank you for the followup on core PR! 👍
After looking at the code, I think it would be nice to clarify where exactly those propos are defined. By that I mean that the props should not be a part of FlatList
and SectionList
, but be listed in VirtualizedList
props, which are than extended but listed earlier components. We already show the parent props link at the top of API documentation.
There were some concerns and benefits around duplicating props of parent in child components, it's fine to leave it as is for now since is a broader topic, but no matter which approach we choose, the VirtualizedList
props also need to be updated:
@Simek Sounds good, I didn’t see that shared doc! Will move onStart/End there. |
@Simek Done! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you for the updates! 👍
We can ship this since changes are already a part of upcoming 0.72 release, but let's wait for one more review, to make sure we are aligned on the approach.
Ping @NickGerleman @cortinico |
I have asked around, and it seems that people do not have a strong preference around that, let's ship this as is. We can always follow up with changes, if someone will find this pattern confusing/cumbersome. 🙂 |
onStartReached
for FlatList and SectionListonEndReached
for FlatList and SectionList