Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a backlink on hermes-as-the-default #3899

Merged
merged 1 commit into from
Oct 25, 2023
Merged

Conversation

Huxpro
Copy link
Contributor

@Huxpro Huxpro commented Oct 24, 2023

Hi ;)

Came across and figured by "last Oct" it was intended to link to my old blog post 😛

@facebook-github-bot
Copy link

Hi @Huxpro!

Thank you for your pull request.

We require contributors to sign our Contributor License Agreement, and yours needs attention.

You currently have a record in our system, but the CLA is no longer valid, and will need to be resubmitted.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@netlify
Copy link

netlify bot commented Oct 24, 2023

Deploy Preview for react-native ready!

Name Link
🔨 Latest commit 5d1f167
🔍 Latest deploy log https://app.netlify.com/sites/react-native/deploys/653856891ef7ba0008924bbc
😎 Deploy Preview https://deploy-preview-3899--react-native.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Huxpro
Copy link
Contributor Author

Huxpro commented Oct 25, 2023

Seems like the CLA is signed according to facebook/jsx#158

Probably need sometime to get the tag added

@cortinico cortinico merged commit 300b602 into facebook:main Oct 25, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants