Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert React Conf 2024 banner #4123

Merged
merged 1 commit into from
May 22, 2024
Merged

Revert React Conf 2024 banner #4123

merged 1 commit into from
May 22, 2024

Conversation

Abbondanzo
Copy link
Contributor

React Conf has sadly ended. Time to revert #4066

Copy link

netlify bot commented May 20, 2024

Deploy Preview for react-native ready!

Name Link
🔨 Latest commit 2011081
🔍 Latest deploy log https://app.netlify.com/sites/react-native/deploys/664b68331e83250008a07c6d
😎 Deploy Preview https://deploy-preview-4123--react-native.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@cortinico
Copy link
Contributor

True, but I'd keep in sync with react.dev (which haven't removed the banner just yet)

@Abbondanzo
Copy link
Contributor Author

True, but I'd keep in sync with react.dev (which haven't removed the banner just yet)

Added a PR to revert the banner on react.dev too: reactjs/react.dev#6891

@Abbondanzo
Copy link
Contributor Author

@cortinico react.dev has removed their banner altogether. I can modify this PR to do the same but it'd be nice to keep the old banner if possible

@cortinico
Copy link
Contributor

react.dev has removed their banner altogether. I can modify this PR to do the same but it'd be nice to keep the old banner if possible

I'd rather keep the two website in sync so let's just remove the banner and follow react.dev

@cortinico cortinico merged commit 16cfcd5 into main May 22, 2024
5 checks passed
@cortinico cortinico deleted the revert-react-conf branch May 22, 2024 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants