Add TypeScript type annotations for improved type safety #4511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for react-native ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Simek
requested changes
Feb 16, 2025
There was a problem hiding this comment.
Files in theme directory comes from Docusaurus swizzle mechanism and they should not be altered without an explicit functional need, since this complicates the upgrade process.
If you would like to see the improved types in there (since they seem to be present in upstream), you should reswizzle the latest version of components, and apply the React Native website custom changes on top of that, instead of typing things manually:
- https://github.com/facebook/docusaurus/blob/75e5a00a66aae4f0e9dfbca9a4c85977028a37b8/packages/docusaurus-theme-classic/src/theme/EditMetaRow/index.tsx
- https://github.com/facebook/docusaurus/blob/75e5a00a66aae4f0e9dfbca9a4c85977028a37b8/packages/docusaurus-theme-classic/src/theme/Blog/Components/Author/index.tsx#L51
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce TypeScript type annotations across various components to enhance type safety and improve type inference for better developer experience.