-
Notifications
You must be signed in to change notification settings - Fork 4.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove outdated and unused design assets #4517
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yup those can go 👍
✅ Deploy Preview for react-native ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We are still using some of the assets from illustrations
directories, and the design
folder is the only place where store sources for them.
Instead of removing those assets sources, we should discuss how we want to preserved the sources, maybe we can create Figma org, and expose them as public file, wdyt @cortinico? Or maybe you have other preference?
Thanks for clarifying. I saw the .sketch file and the React Icon and I was fairly sure nothing of that is used. We can keep them here if we don't have a better place |
if we're sticking with committing a design file then it's probably a better idea to commit a figma file since sketch is macos only. @Simek exposing a public figma project url seems like a good idea to avoid bloating the repo |
@cortinico actually i checked and the files in the design folder aren't being referenced anywhere. i believe they were used to generate static assets but haven't been updated since. |
Eliminate design assets that are no longer in use.
last update was 6 years ago and i don't think they're used anywhere so they're bloating the repo