Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove outdated and unused design assets #4517

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

hichemfantar
Copy link
Contributor

@hichemfantar hichemfantar commented Feb 19, 2025

Eliminate design assets that are no longer in use.
last update was 6 years ago and i don't think they're used anywhere so they're bloating the repo

Copy link
Contributor

@cortinico cortinico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup those can go 👍

@hichemfantar hichemfantar changed the title Remove unused design assets Remove outdated and unused design assets Feb 19, 2025
@hichemfantar hichemfantar marked this pull request as ready for review February 19, 2025 11:28
Copy link

netlify bot commented Feb 19, 2025

Deploy Preview for react-native ready!

Name Link
🔨 Latest commit 2570860
🔍 Latest deploy log https://app.netlify.com/sites/react-native/deploys/67b5bfabcab84c0008d1bca1
😎 Deploy Preview https://deploy-preview-4517--react-native.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Collaborator

@Simek Simek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are still using some of the assets from illustrations directories, and the design folder is the only place where store sources for them.

Instead of removing those assets sources, we should discuss how we want to preserved the sources, maybe we can create Figma org, and expose them as public file, wdyt @cortinico? Or maybe you have other preference?

@cortinico
Copy link
Contributor

We are still using some of the assets from illustrations directories, and the design folder is the only place where store sources for them.

Thanks for clarifying. I saw the .sketch file and the React Icon and I was fairly sure nothing of that is used. We can keep them here if we don't have a better place

@hichemfantar
Copy link
Contributor Author

if we're sticking with committing a design file then it's probably a better idea to commit a figma file since sketch is macos only.

@Simek exposing a public figma project url seems like a good idea to avoid bloating the repo

@hichemfantar
Copy link
Contributor Author

@cortinico actually i checked and the files in the design folder aren't being referenced anywhere. i believe they were used to generate static assets but haven't been updated since.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants