Skip to content

Commit

Permalink
fix(jest-env): pass exportConditions (#35203)
Browse files Browse the repository at this point in the history
Summary:
Like discussed in react-native-community/discussions-and-proposals#509, RN should override the default `node` and `node-addons` conditions.

You might consider supporting (or just setting) [`customExportConditions`](https://github.com/facebook/jest/blob/4670d3be0d80d47844673eb163666253e788f006/packages/jest-environment-node/src/index.ts#L187-L189) instead, but the default of the node env should be overwritten 🙂

## Changelog

<!-- Help reviewers and the release process by writing your own changelog entry. For an example, see:
https://reactnative.dev/contributing/changelogs-in-pull-requests
-->

[General] [Changed] - use `'react-native'` export conditions in Jest environment

Pull Request resolved: #35203

Test Plan: Green CI?

Reviewed By: lunaleaps

Differential Revision: D41081783

Pulled By: jacdebug

fbshipit-source-id: 844c70d92a58c5432ba5b9e5e99c8f50045ef8ac
  • Loading branch information
SimenB authored and facebook-github-bot committed Nov 10, 2022
1 parent 3d9a3b7 commit 0376aa4
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion jest/react-native-env.js
Original file line number Diff line number Diff line change
Expand Up @@ -12,5 +12,7 @@
const NodeEnv = require('jest-environment-node').TestEnvironment;

module.exports = class ReactNativeEnv extends NodeEnv {
// this is where we'll add our custom logic
exportConditions() {
return ['react-native'];
}
};

0 comments on commit 0376aa4

Please sign in to comment.