Cleanup Fresco SystraceRequestRequestListener (#46626)

Summary:
Pull Request resolved: #46626

Remove `!!` by reusing lookup result.

Changelog: [Internal]

Reviewed By: mdvacca

Differential Revision: D63316175

fbshipit-source-id: 1abfb20490831f26819aef4393c9629253d33ec6

packages/react-native/ReactAndroid/src/main/java/com/facebook/react/modules/fresco/SystraceRequestListener.kt

@@ -15,8 +15,8 @@ import com.facebook.systrace.Systrace
 /** Logs requests to Systrace */
 public class SystraceRequestListener : BaseRequestListener() {
   private var currentId: Int = 0
-  private var producerId: MutableMap<String, Pair<Int, String>> = mutableMapOf()
-  private var requestsId: MutableMap<String, Pair<Int, String>> = mutableMapOf()
+  private val producerId: MutableMap<String, Pair<Int, String>> = mutableMapOf()
+  private val requestsId: MutableMap<String, Pair<Int, String>> = mutableMapOf()
 
   override fun onProducerStart(requestId: String, producerName: String) {
     if (!Systrace.isTracing(Systrace.TRACE_TAG_REACT_FRESCO)) {
@@ -39,8 +39,9 @@ public class SystraceRequestListener : BaseRequestListener() {
     if (!Systrace.isTracing(Systrace.TRACE_TAG_REACT_FRESCO)) {
       return
     }
-    if (producerId.containsKey(requestId)) {
-      val entry = producerId[requestId]!!
+
+    val entry = producerId[requestId]
+    if (entry != null) {
       Systrace.endAsyncSection(Systrace.TRACE_TAG_REACT_FRESCO, entry.second, entry.first)
       producerId.remove(requestId)
     }
@@ -55,8 +56,9 @@ public class SystraceRequestListener : BaseRequestListener() {
     if (!Systrace.isTracing(Systrace.TRACE_TAG_REACT_FRESCO)) {
       return
     }
-    if (producerId.containsKey(requestId)) {
-      val entry = producerId[requestId]!!
+
+    val entry = producerId[requestId]
+    if (entry != null) {
       Systrace.endAsyncSection(Systrace.TRACE_TAG_REACT_FRESCO, entry.second, entry.first)
       producerId.remove(requestId)
     }
@@ -70,8 +72,9 @@ public class SystraceRequestListener : BaseRequestListener() {
     if (!Systrace.isTracing(Systrace.TRACE_TAG_REACT_FRESCO)) {
       return
     }
-    if (producerId.containsKey(requestId)) {
-      val entry = producerId[requestId]!!
+
+    val entry = producerId[requestId]
+    if (entry != null) {
       Systrace.endAsyncSection(Systrace.TRACE_TAG_REACT_FRESCO, entry.second, entry.first)
       producerId.remove(requestId)
     }
@@ -101,6 +104,7 @@ public class SystraceRequestListener : BaseRequestListener() {
     if (!Systrace.isTracing(Systrace.TRACE_TAG_REACT_FRESCO)) {
       return
     }
+
     val entryName = StringBuilder()
     entryName.append("FRESCO_REQUEST_")
     entryName.append(request.sourceUri.toString().replace(':', '_'))
@@ -114,8 +118,9 @@ public class SystraceRequestListener : BaseRequestListener() {
     if (!Systrace.isTracing(Systrace.TRACE_TAG_REACT_FRESCO)) {
       return
     }
-    if (requestsId.containsKey(requestId)) {
-      val entry = requestsId[requestId]!!
+
+    val entry = requestsId[requestId]
+    if (entry != null) {
       Systrace.endAsyncSection(Systrace.TRACE_TAG_REACT_FRESCO, entry.second, entry.first)
       requestsId.remove(requestId)
     }
@@ -130,8 +135,9 @@ public class SystraceRequestListener : BaseRequestListener() {
     if (!Systrace.isTracing(Systrace.TRACE_TAG_REACT_FRESCO)) {
       return
     }
-    if (requestsId.containsKey(requestId)) {
-      val entry = requestsId[requestId]!!
+
+    val entry = requestsId[requestId]
+    if (entry != null) {
       Systrace.endAsyncSection(Systrace.TRACE_TAG_REACT_FRESCO, entry.second, entry.first)
       requestsId.remove(requestId)
     }
@@ -141,8 +147,9 @@ public class SystraceRequestListener : BaseRequestListener() {
     if (!Systrace.isTracing(Systrace.TRACE_TAG_REACT_FRESCO)) {
       return
     }
-    if (requestsId.containsKey(requestId)) {
-      val entry = requestsId[requestId]!!
+
+    val entry = requestsId[requestId]
+    if (entry != null) {
       Systrace.endAsyncSection(Systrace.TRACE_TAG_REACT_FRESCO, entry.second, entry.first)
       requestsId.remove(requestId)
     }