Internal API for Activity-less "Paused in debugger" overlay (#44132)

Summary:
Pull Request resolved: #44132

Changelog: [Breaking][Android] `DevSupportManagerFactory.create()` changed to take an additional parameter of type `PausedInDebuggerOverlayManager` (nullable)

Enables integrators of React Native Android to supply their own implementation of the Fusebox "paused in debugger" overlay. This is primarily intended for legacy Meta-internal integrations that can't use the built-in implementation based on `Dialog`. **The API will likely go away once those integrations have been migrated.**

Reviewed By: javache

Differential Revision: D56215119

fbshipit-source-id: 9cd79a6948c268a952ac28e5563ae57c90756da7

packages/react-native/ReactAndroid/api/ReactAndroid.api

@@ -297,6 +297,7 @@ public class com/facebook/react/ReactInstanceManagerBuilder {
  public fun setLazyViewManagersEnabled (Z)Lcom/facebook/react/ReactInstanceManagerBuilder;
  public fun setMinNumShakes (I)Lcom/facebook/react/ReactInstanceManagerBuilder;
  public fun setMinTimeLeftInFrameForNonBatchedOperationMs (I)Lcom/facebook/react/ReactInstanceManagerBuilder;
+ public fun setPausedInDebuggerOverlayManager (Lcom/facebook/react/devsupport/interfaces/PausedInDebuggerOverlayManager;)Lcom/facebook/react/ReactInstanceManagerBuilder;
  public fun setReactPackageTurboModuleManagerDelegateBuilder (Lcom/facebook/react/ReactPackageTurboModuleManagerDelegate$Builder;)Lcom/facebook/react/ReactInstanceManagerBuilder;
  public fun setRedBoxHandler (Lcom/facebook/react/devsupport/interfaces/RedBoxHandler;)Lcom/facebook/react/ReactInstanceManagerBuilder;
  public fun setRequireActivity (Z)Lcom/facebook/react/ReactInstanceManagerBuilder;
@@ -321,6 +322,7 @@ public abstract class com/facebook/react/ReactNativeHost {
  protected fun getJavaScriptExecutorFactory ()Lcom/facebook/react/bridge/JavaScriptExecutorFactory;
  public fun getLazyViewManagersEnabled ()Z
  protected abstract fun getPackages ()Ljava/util/List;
+ protected fun getPausedInDebuggerOverlayManager ()Lcom/facebook/react/devsupport/interfaces/PausedInDebuggerOverlayManager;
  public fun getReactInstanceManager ()Lcom/facebook/react/ReactInstanceManager;
  protected fun getReactPackageTurboModuleManagerDelegateBuilder ()Lcom/facebook/react/ReactPackageTurboModuleManagerDelegate$Builder;
  protected fun getRedBoxHandler ()Lcom/facebook/react/devsupport/interfaces/RedBoxHandler;
@@ -2031,7 +2033,7 @@ public final class com/facebook/react/defaults/DefaultTurboModuleManagerDelegate
 }
 
 public final class com/facebook/react/devsupport/BridgeDevSupportManager : com/facebook/react/devsupport/DevSupportManagerBase {
- public fun <init> (Landroid/content/Context;Lcom/facebook/react/devsupport/ReactInstanceDevHelper;Ljava/lang/String;ZLcom/facebook/react/devsupport/interfaces/RedBoxHandler;Lcom/facebook/react/devsupport/interfaces/DevBundleDownloadListener;ILjava/util/Map;Lcom/facebook/react/common/SurfaceDelegateFactory;Lcom/facebook/react/devsupport/interfaces/DevLoadingViewManager;)V
+ public fun <init> (Landroid/content/Context;Lcom/facebook/react/devsupport/ReactInstanceDevHelper;Ljava/lang/String;ZLcom/facebook/react/devsupport/interfaces/RedBoxHandler;Lcom/facebook/react/devsupport/interfaces/DevBundleDownloadListener;ILjava/util/Map;Lcom/facebook/react/common/SurfaceDelegateFactory;Lcom/facebook/react/devsupport/interfaces/DevLoadingViewManager;Lcom/facebook/react/devsupport/interfaces/PausedInDebuggerOverlayManager;)V
  public fun handleReloadJS ()V
  public fun loadSplitBundleFromServer (Ljava/lang/String;Lcom/facebook/react/devsupport/interfaces/DevSplitBundleCallback;)V
 }
@@ -2061,7 +2063,7 @@ public class com/facebook/react/devsupport/DefaultDevLoadingViewImplementation :
 public final class com/facebook/react/devsupport/DefaultDevSupportManagerFactory : com/facebook/react/devsupport/DevSupportManagerFactory {
  public fun <init> ()V
  public final fun create (Landroid/content/Context;Lcom/facebook/react/devsupport/ReactInstanceDevHelper;Ljava/lang/String;ZI)Lcom/facebook/react/devsupport/interfaces/DevSupportManager;
- public fun create (Landroid/content/Context;Lcom/facebook/react/devsupport/ReactInstanceDevHelper;Ljava/lang/String;ZLcom/facebook/react/devsupport/interfaces/RedBoxHandler;Lcom/facebook/react/devsupport/interfaces/DevBundleDownloadListener;ILjava/util/Map;Lcom/facebook/react/common/SurfaceDelegateFactory;Lcom/facebook/react/devsupport/interfaces/DevLoadingViewManager;)Lcom/facebook/react/devsupport/interfaces/DevSupportManager;
+ public fun create (Landroid/content/Context;Lcom/facebook/react/devsupport/ReactInstanceDevHelper;Ljava/lang/String;ZLcom/facebook/react/devsupport/interfaces/RedBoxHandler;Lcom/facebook/react/devsupport/interfaces/DevBundleDownloadListener;ILjava/util/Map;Lcom/facebook/react/common/SurfaceDelegateFactory;Lcom/facebook/react/devsupport/interfaces/DevLoadingViewManager;Lcom/facebook/react/devsupport/interfaces/PausedInDebuggerOverlayManager;)Lcom/facebook/react/devsupport/interfaces/DevSupportManager;
 }
 
 public class com/facebook/react/devsupport/DevServerHelper {
@@ -2101,7 +2103,7 @@ public final class com/facebook/react/devsupport/DevSettingsActivity : android/p
 }
 
 public abstract class com/facebook/react/devsupport/DevSupportManagerBase : com/facebook/react/devsupport/interfaces/DevSupportManager {
- public fun <init> (Landroid/content/Context;Lcom/facebook/react/devsupport/ReactInstanceDevHelper;Ljava/lang/String;ZLcom/facebook/react/devsupport/interfaces/RedBoxHandler;Lcom/facebook/react/devsupport/interfaces/DevBundleDownloadListener;ILjava/util/Map;Lcom/facebook/react/common/SurfaceDelegateFactory;Lcom/facebook/react/devsupport/interfaces/DevLoadingViewManager;)V
+ public fun <init> (Landroid/content/Context;Lcom/facebook/react/devsupport/ReactInstanceDevHelper;Ljava/lang/String;ZLcom/facebook/react/devsupport/interfaces/RedBoxHandler;Lcom/facebook/react/devsupport/interfaces/DevBundleDownloadListener;ILjava/util/Map;Lcom/facebook/react/common/SurfaceDelegateFactory;Lcom/facebook/react/devsupport/interfaces/DevLoadingViewManager;Lcom/facebook/react/devsupport/interfaces/PausedInDebuggerOverlayManager;)V
  public fun addCustomDevOption (Ljava/lang/String;Lcom/facebook/react/devsupport/interfaces/DevOptionHandler;)V
  public fun createRootView (Ljava/lang/String;)Landroid/view/View;
  public fun createSurfaceDelegate (Ljava/lang/String;)Lcom/facebook/react/common/SurfaceDelegate;
@@ -2164,7 +2166,7 @@ public abstract interface class com/facebook/react/devsupport/DevSupportManagerB
 }
 
 public abstract interface class com/facebook/react/devsupport/DevSupportManagerFactory {
- public abstract fun create (Landroid/content/Context;Lcom/facebook/react/devsupport/ReactInstanceDevHelper;Ljava/lang/String;ZLcom/facebook/react/devsupport/interfaces/RedBoxHandler;Lcom/facebook/react/devsupport/interfaces/DevBundleDownloadListener;ILjava/util/Map;Lcom/facebook/react/common/SurfaceDelegateFactory;Lcom/facebook/react/devsupport/interfaces/DevLoadingViewManager;)Lcom/facebook/react/devsupport/interfaces/DevSupportManager;
+ public abstract fun create (Landroid/content/Context;Lcom/facebook/react/devsupport/ReactInstanceDevHelper;Ljava/lang/String;ZLcom/facebook/react/devsupport/interfaces/RedBoxHandler;Lcom/facebook/react/devsupport/interfaces/DevBundleDownloadListener;ILjava/util/Map;Lcom/facebook/react/common/SurfaceDelegateFactory;Lcom/facebook/react/devsupport/interfaces/DevLoadingViewManager;Lcom/facebook/react/devsupport/interfaces/PausedInDebuggerOverlayManager;)Lcom/facebook/react/devsupport/interfaces/DevSupportManager;
 }
 
 public final class com/facebook/react/devsupport/DoubleTapReloadRecognizer {
@@ -2461,6 +2463,11 @@ public abstract interface class com/facebook/react/devsupport/interfaces/Package
  public abstract fun onPackagerStatusFetched (Z)V
 }
 
+public abstract interface class com/facebook/react/devsupport/interfaces/PausedInDebuggerOverlayManager {
+ public abstract fun hidePausedInDebuggerOverlay ()V
+ public abstract fun showPausedInDebuggerOverlay (Ljava/lang/String;Lcom/facebook/react/devsupport/interfaces/DevSupportManager$PausedInDebuggerOverlayCommandListener;)V
+}
+
 public abstract interface class com/facebook/react/devsupport/interfaces/RedBoxHandler {
  public abstract fun handleRedbox (Ljava/lang/String;[Lcom/facebook/react/devsupport/interfaces/StackFrame;Lcom/facebook/react/devsupport/interfaces/ErrorType;)V
  public abstract fun isReportEnabled ()Z

packages/react-native/ReactAndroid/src/main/java/com/facebook/react/ReactInstanceManager.java

@@ -89,6 +89,7 @@
 import com.facebook.react.devsupport.interfaces.DevSupportManager;
 import com.facebook.react.devsupport.interfaces.DevSupportManager.PausedInDebuggerOverlayCommandListener;
 import com.facebook.react.devsupport.interfaces.PackagerStatusCallback;
+import com.facebook.react.devsupport.interfaces.PausedInDebuggerOverlayManager;
 import com.facebook.react.devsupport.interfaces.RedBoxHandler;
 import com.facebook.react.internal.AndroidChoreographerProvider;
 import com.facebook.react.internal.ChoreographerProvider;
@@ -244,7 +245,8 @@ public static ReactInstanceManagerBuilder builder() {
  @Nullable ReactPackageTurboModuleManagerDelegate.Builder tmmDelegateBuilder,
  @Nullable SurfaceDelegateFactory surfaceDelegateFactory,
  @Nullable DevLoadingViewManager devLoadingViewManager,
- @Nullable ChoreographerProvider choreographerProvider) {
+ @Nullable ChoreographerProvider choreographerProvider,
+ @Nullable PausedInDebuggerOverlayManager pausedInDebuggerOverlayManager) {
  FLog.d(TAG, "ReactInstanceManager.ctor()");
  initializeSoLoaderIfNecessary(applicationContext);
 
@@ -274,7 +276,8 @@ public static ReactInstanceManagerBuilder builder() {
  minNumShakes,
  customPackagerCommandHandlers,
  surfaceDelegateFactory,
- devLoadingViewManager);
+ devLoadingViewManager,
+ pausedInDebuggerOverlayManager);
  Systrace.endSection(TRACE_TAG_REACT_JAVA_BRIDGE);
  mBridgeIdleDebugListener = bridgeIdleDebugListener;
  mLifecycleState = initialLifecycleState;

packages/react-native/ReactAndroid/src/main/java/com/facebook/react/ReactInstanceManagerBuilder.java

@@ -31,6 +31,7 @@
 import com.facebook.react.devsupport.interfaces.DevBundleDownloadListener;
 import com.facebook.react.devsupport.interfaces.DevLoadingViewManager;
 import com.facebook.react.devsupport.interfaces.DevSupportManager;
+import com.facebook.react.devsupport.interfaces.PausedInDebuggerOverlayManager;
 import com.facebook.react.devsupport.interfaces.RedBoxHandler;
 import com.facebook.react.internal.ChoreographerProvider;
 import com.facebook.react.jscexecutor.JSCExecutor;
@@ -75,6 +76,7 @@ public class ReactInstanceManagerBuilder {
  private @Nullable DevLoadingViewManager mDevLoadingViewManager;
  private @Nullable JSEngineResolutionAlgorithm mJSEngineResolutionAlgorithm = null;
  private @Nullable ChoreographerProvider mChoreographerProvider = null;
+ private @Nullable PausedInDebuggerOverlayManager mPausedInDebuggerOverlayManager = null;
 
  /* package protected */ ReactInstanceManagerBuilder() {}
 
@@ -235,6 +237,12 @@ public ReactInstanceManagerBuilder setDevLoadingViewManager(
  return this;
  }
 
+ public ReactInstanceManagerBuilder setPausedInDebuggerOverlayManager(
+ @Nullable PausedInDebuggerOverlayManager pausedInDebuggerOverlayManager) {
+ mPausedInDebuggerOverlayManager = pausedInDebuggerOverlayManager;
+ return this;
+ }
+
  /**
  * Sets the initial lifecycle state of the host. For example, if the host is already resumed at
  * creation time, we wouldn't expect an onResume call until we get an onPause call.
@@ -365,7 +373,8 @@ public ReactInstanceManager build() {
  mTMMDelegateBuilder,
  mSurfaceDelegateFactory,
  mDevLoadingViewManager,
- mChoreographerProvider);
+ mChoreographerProvider,
+ mPausedInDebuggerOverlayManager);
  }
 
  private JavaScriptExecutorFactory getDefaultJSExecutorFactory(

packages/react-native/ReactAndroid/src/main/java/com/facebook/react/ReactNativeHost.java

@@ -20,6 +20,7 @@
 import com.facebook.react.common.annotations.DeprecatedInNewArchitecture;
 import com.facebook.react.devsupport.DevSupportManagerFactory;
 import com.facebook.react.devsupport.interfaces.DevLoadingViewManager;
+import com.facebook.react.devsupport.interfaces.PausedInDebuggerOverlayManager;
 import com.facebook.react.devsupport.interfaces.RedBoxHandler;
 import com.facebook.react.internal.ChoreographerProvider;
 import java.util.List;
@@ -96,7 +97,8 @@ protected ReactInstanceManagerBuilder getBaseReactInstanceManagerBuilder() {
  .setReactPackageTurboModuleManagerDelegateBuilder(
  getReactPackageTurboModuleManagerDelegateBuilder())
  .setJSEngineResolutionAlgorithm(getJSEngineResolutionAlgorithm())
- .setChoreographerProvider(getChoreographerProvider());
+ .setChoreographerProvider(getChoreographerProvider())
+ .setPausedInDebuggerOverlayManager(getPausedInDebuggerOverlayManager());
 
  for (ReactPackage reactPackage : getPackages()) {
  builder.addPackage(reactPackage);
@@ -171,6 +173,10 @@ public SurfaceDelegateFactory getSurfaceDelegateFactory() {
  return null;
  }
 
+ protected @Nullable PausedInDebuggerOverlayManager getPausedInDebuggerOverlayManager() {
+ return null;
+ }
+
  /**
  * Returns the name of the main module. Determines the URL used to fetch the JS bundle from Metro.
  * It is only used when dev support is enabled. This is the first file to be executed once the

packages/react-native/ReactAndroid/src/main/java/com/facebook/react/devsupport/BridgeDevSupportManager.java

@@ -29,6 +29,7 @@
 import com.facebook.react.devsupport.interfaces.DevLoadingViewManager;
 import com.facebook.react.devsupport.interfaces.DevOptionHandler;
 import com.facebook.react.devsupport.interfaces.DevSplitBundleCallback;
+import com.facebook.react.devsupport.interfaces.PausedInDebuggerOverlayManager;
 import com.facebook.react.devsupport.interfaces.RedBoxHandler;
 import com.facebook.react.packagerconnection.RequestHandler;
 import java.io.File;
@@ -74,7 +75,8 @@ public BridgeDevSupportManager(
  int minNumShakes,
  @Nullable Map<String, RequestHandler> customPackagerCommandHandlers,
  @Nullable SurfaceDelegateFactory surfaceDelegateFactory,
- @Nullable DevLoadingViewManager devLoadingViewManager) {
+ @Nullable DevLoadingViewManager devLoadingViewManager,
+ @Nullable PausedInDebuggerOverlayManager pausedInDebuggerOverlayManager) {
  super(
  applicationContext,
  reactInstanceManagerHelper,
@@ -85,7 +87,8 @@ public BridgeDevSupportManager(
  minNumShakes,
  customPackagerCommandHandlers,
  surfaceDelegateFactory,
- devLoadingViewManager);
+ devLoadingViewManager,
+ pausedInDebuggerOverlayManager);
 
  if (getDevSettings().isStartSamplingProfilerOnInit()) {
  // Only start the profiler. If its already running, there is an error

packages/react-native/ReactAndroid/src/main/java/com/facebook/react/devsupport/DefaultDevSupportManagerFactory.kt

@@ -12,6 +12,7 @@ import com.facebook.react.common.SurfaceDelegateFactory
 import com.facebook.react.devsupport.interfaces.DevBundleDownloadListener
 import com.facebook.react.devsupport.interfaces.DevLoadingViewManager
 import com.facebook.react.devsupport.interfaces.DevSupportManager
+import com.facebook.react.devsupport.interfaces.PausedInDebuggerOverlayManager
 import com.facebook.react.devsupport.interfaces.RedBoxHandler
 import com.facebook.react.packagerconnection.RequestHandler
 
@@ -25,7 +26,7 @@ public class DefaultDevSupportManagerFactory : DevSupportManagerFactory {
  @Deprecated(
  "in favor of the customisable create for DevSupportManagerFactory",
  ReplaceWith(
- "create(applicationContext, reactInstanceManagerHelper, packagerPathForJSBundleName, enableOnCreate, redBoxHandler, devBundleDownloadListener, minNumShakes, customPackagerCommandHandlers, surfaceDelegateFactory, devLoadingViewManager)"))
+ "create(applicationContext, reactInstanceManagerHelper, packagerPathForJSBundleName, enableOnCreate, redBoxHandler, devBundleDownloadListener, minNumShakes, customPackagerCommandHandlers, surfaceDelegateFactory, devLoadingViewManager, pausedInDebuggerOverlayManager)"))
  public fun create(
  applicationContext: Context,
  reactInstanceDevHelper: ReactInstanceDevHelper,
@@ -43,6 +44,7 @@ public class DefaultDevSupportManagerFactory : DevSupportManagerFactory {
  minNumShakes,
  null,
  null,
+ null,
  null)
  }
 
@@ -56,7 +58,8 @@ public class DefaultDevSupportManagerFactory : DevSupportManagerFactory {
  minNumShakes: Int,
  customPackagerCommandHandlers: Map<String, RequestHandler>?,
  surfaceDelegateFactory: SurfaceDelegateFactory?,
- devLoadingViewManager: DevLoadingViewManager?
+ devLoadingViewManager: DevLoadingViewManager?,
+ pausedInDebuggerOverlayManager: PausedInDebuggerOverlayManager?
  ): DevSupportManager {
  return if (!enableOnCreate) {
  ReleaseDevSupportManager()
@@ -88,7 +91,8 @@ public class DefaultDevSupportManagerFactory : DevSupportManagerFactory {
  Int::class.javaPrimitiveType,
  MutableMap::class.java,
  SurfaceDelegateFactory::class.java,
- DevLoadingViewManager::class.java)
+ DevLoadingViewManager::class.java,
+ PausedInDebuggerOverlayManager::class.java)
  constructor.newInstance(
  applicationContext,
  reactInstanceManagerHelper,
@@ -99,7 +103,8 @@ public class DefaultDevSupportManagerFactory : DevSupportManagerFactory {
  minNumShakes,
  customPackagerCommandHandlers,
  surfaceDelegateFactory,
- devLoadingViewManager) as DevSupportManager
+ devLoadingViewManager,
+ pausedInDebuggerOverlayManager) as DevSupportManager
  } catch (e: Exception) {
  PerftestDevSupportManager(applicationContext)
  }