Skip to content

Commit

Permalink
Static link for hermes-inspector (#32694)
Browse files Browse the repository at this point in the history
Summary:
Follow up to #32683 to also link hermes-inspector statically.

## Changelog

[Android] [Fix] - Static link for hermes-inspector

Pull Request resolved: #32694

Test Plan: Tested a clean build and made sure hermes-inspector.so doesn't exist anymore.

Reviewed By: cortinico

Differential Revision: D32791208

Pulled By: ShikaSD

fbshipit-source-id: 6076b263469b9e2c6176d488d13292d4f1731dcc
  • Loading branch information
janicduplessis authored and facebook-github-bot committed Dec 13, 2021
1 parent b30ff98 commit 20b0eba
Show file tree
Hide file tree
Showing 4 changed files with 2 additions and 4 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ LOCAL_C_INCLUDES := $(LOCAL_PATH) $(REACT_NATIVE)/ReactCommon/jsi $(call find-no

LOCAL_CPP_FEATURES := exceptions

LOCAL_STATIC_LIBRARIES := libjsireact libhermes-executor-common-debug libhermes-inspector
LOCAL_STATIC_LIBRARIES := libjsireact libhermes-executor-common-debug
LOCAL_SHARED_LIBRARIES := \
libfb \
libfbjni \
Expand Down
2 changes: 1 addition & 1 deletion ReactCommon/hermes/inspector/Android.mk
Original file line number Diff line number Diff line change
Expand Up @@ -31,4 +31,4 @@ LOCAL_SHARED_LIBRARIES := \
libhermes \
libjsi

include $(BUILD_SHARED_LIBRARY)
include $(BUILD_STATIC_LIBRARY)
Original file line number Diff line number Diff line change
Expand Up @@ -231,7 +231,6 @@ private fun Project.cleanupVMFiles(

if (cleanup) {
// Reduce size by deleting the debugger/inspector
it.include("**/libhermes-inspector.so")
it.include("**/libhermes-executor-debug.so")
} else {
// Release libs take precedence and must be removed
Expand Down
1 change: 0 additions & 1 deletion react.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -363,7 +363,6 @@ afterEvaluate {

if (cleanup) {
// Reduce size by deleting the debugger/inspector
include '**/libhermes-inspector.so'
include '**/libhermes-executor-debug.so'
} else {
// Release libs take precedence and must be removed
Expand Down

0 comments on commit 20b0eba

Please sign in to comment.