Skip to content

Commit

Permalink
Disabled cpp view managers in runtime
Browse files Browse the repository at this point in the history
Summary:
We found this feature crashing the app during hot reload, and as there is no user code dependent on it so far, we decided to disable it until we find the root cause.

changelog: [internal] internal

Reviewed By: mdvacca

Differential Revision: D40445312

fbshipit-source-id: fe28b58c5dca6c91389ad38675ca37669a4965a0
  • Loading branch information
arhelmus authored and facebook-github-bot committed Oct 17, 2022
1 parent 55fca7f commit 31f2199
Showing 1 changed file with 5 additions and 3 deletions.
8 changes: 5 additions & 3 deletions ReactAndroid/src/main/jni/react/fabric/Binding.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -377,9 +377,11 @@ void Binding::installFabricUIManager(
<< this << ").";
}

sharedCppComponentRegistry_ =
std::shared_ptr<const facebook::react::CppComponentRegistry>(
cppComponentRegistry ? cppComponentRegistry : nullptr);
// TODO[T135327389]: Investigate why code relying on CppComponentRegistry
// crashing during hot reload restart.
// sharedCppComponentRegistry_ =
// std::shared_ptr<const facebook::react::CppComponentRegistry>(
// cppComponentRegistry ? cppComponentRegistry : nullptr);

// Use std::lock and std::adopt_lock to prevent deadlocks by locking mutexes
// at the same time
Expand Down

0 comments on commit 31f2199

Please sign in to comment.