Skip to content

Commit

Permalink
React Native: disable multipart bundle transmission for now
Browse files Browse the repository at this point in the history 
Reviewed By: davidaurelio

Differential Revision: D5329011

fbshipit-source-id: 5093bc5b1858314512313934fba04f4343fe0d5b
  • Loading branch information
@facebook-github-bot
Jean Lauliac authored and facebook-github-bot committed Jun 29, 2017
1 parent d666f30 commit 33057aa
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion ReactAndroid/src/main/java/com/facebook/react/devsupport/BundleDownloader.java
View file
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,10 @@ public void downloadBundleFromURL(
final String bundleURL) {
final Request request = new Request.Builder()
.url(bundleURL)
.addHeader("Accept", "multipart/mixed")
// FIXME: there is a bug that makes MultipartStreamReader to never find the end of the
// multipart message. This temporarily disables the multipart mode to work around it, but
// it means there is no progress bar displayed in the React Native overlay anymore.
//.addHeader("Accept", "multipart/mixed")
.build();
mDownloadBundleFromURLCall = Assertions.assertNotNull(mClient.newCall(request));
mDownloadBundleFromURLCall.enqueue(new Callback() {
Expand Down

2 comments on commit 33057aa

@janicduplessis
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jeanlauliac Do you have a repro so I can try fixing this?

@jeanlauliac
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm afraid I don't have a minimal repro. We can repro on our internal Android package and have a task to track this. I'll see if I can create a minimal repro.

Please sign in to comment.