Skip to content

Commit

Permalink
Sort parameters in DefaultNewArchitectureEntryPoint (#35115)
Browse files Browse the repository at this point in the history
Summary:
Pull Request resolved: #35115

When looking at the new entry point I've realized we have the dynamicLibraryName as first parameter.
As this API is not released yet, let's move it as last.

So users on Java can easily call DefaultNewArchitectureEntryPoint.load(true, true, true)
while now they will have to call DefaultNewArchitectureEntryPoint.load("...", true, true, true)

Users in Kotlin won't be affected by this.

Changelog:
[Internal] [Changed] - Sort parameters in DefaultNewArchitectureEntryPoint

Reviewed By: cipolleschi

Differential Revision: D40793370

fbshipit-source-id: 9dc1569d76a1479a738f8e0f41a4183d7c04538f
  • Loading branch information
cortinico authored and facebook-github-bot committed Oct 28, 2022
1 parent 089684e commit 3dc7b37
Showing 1 changed file with 2 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -25,10 +25,10 @@ object DefaultNewArchitectureEntryPoint {
@JvmStatic
@JvmOverloads
fun load(
dynamicLibraryName: String = "appmodules",
turboModulesEnabled: Boolean = true,
fabricEnabled: Boolean = true,
concurrentReactEnabled: Boolean = true
concurrentReactEnabled: Boolean = true,
dynamicLibraryName: String = "appmodules",
) {
ReactFeatureFlags.useTurboModules = turboModulesEnabled
ReactFeatureFlags.enableFabricRenderer = fabricEnabled
Expand Down

0 comments on commit 3dc7b37

Please sign in to comment.