Copy data in updateState instead of moving them

Summary:
Changelog: [internal]

`UpdateState` lambda can be called multiple times because of state auto-repeater. But previously we moved state data into the lambda and then moved it into constructor shared data constructor. If auto-repeater called update state lambda again, the data would be in invalid state.
To fix this, state data has to be copied into shared data constructor.

Background executor was more likely to kick trigger state auto-repeater, that's why the crash was happening in BE experiment.
State-autorepeater was enabled at the end of December. That explains why the crash started appearing in v301 (prior to 301, this crash was not happening).

Reviewed By: JoshuaGross, shergin

Differential Revision: D26173800

fbshipit-source-id: 46d1bae226e607d04d5ba28e6c2a8ec86258593a

ReactCommon/react/renderer/core/ConcreteState.h

@@ -62,8 +62,8 @@ class ConcreteState : public State {
  Data &&newData,
  EventPriority priority = EventPriority::AsynchronousUnbatched) const {
  updateState(
- [data = std::move(newData)](Data const &oldData) mutable -> SharedData {
- return std::make_shared<Data const>(std::move(data));
+ [data{std::move(newData)}](Data const &oldData) -> SharedData {
+ return std::make_shared<Data const>(data);
  },
  priority);
  }