Skip to content

Commit

Permalink
infra(e2e): fix enabling new arch for RNTester iOS in the E2E script (#…
Browse files Browse the repository at this point in the history
…34882)

Summary:
Quick follow up to #34513 to fix an issue that has been bothering the release crew for a while: the iOS new arch component not working! Turns out, we're silly billies �

## Changelog

<!-- Help reviewers and the release process by writing your own changelog entry. For an example, see:
https://reactnative.dev/contributing/changelogs-in-pull-requests
-->

[Internal] [Changed] - Add new arch flag to iOS pod install command in E2E script

Pull Request resolved: #34882

Test Plan:
Everything works correctly now:

<img width="987" alt="Screenshot 2022-10-06 at 14 20 09" src="https://user-images.githubusercontent.com/16104054/194327768-4da7d607-879b-46ad-a453-504983980831.png">

Reviewed By: dmytrorykun

Differential Revision: D40143251

Pulled By: dmytrorykun

fbshipit-source-id: 91ba6e22c25770efe6a839d6728d7052bc17a8f2
  • Loading branch information
kelset authored and facebook-github-bot committed Oct 7, 2022
1 parent 2afcea2 commit 6552d47
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions scripts/test-e2e-local.js
Original file line number Diff line number Diff line change
Expand Up @@ -74,12 +74,12 @@ if (argv.target === 'RNTester') {
console.info(
`We're going to test the ${
argv.hermes ? 'Hermes' : 'JSC'
} version of RNTester iOS`,
} version of RNTester iOS with the new Architecture enabled`,
);
exec(
`cd packages/rn-tester && USE_HERMES=${
argv.hermes ? 1 : 0
} bundle exec pod install --ansi`,
} RCT_NEW_ARCH_ENABLED=1 bundle exec pod install --ansi`,
);

// if everything succeeded so far, we can launch Metro and the app
Expand All @@ -98,7 +98,7 @@ if (argv.target === 'RNTester') {
console.info(
`We're going to test the ${
argv.hermes ? 'Hermes' : 'JSC'
} version of RNTester Android`,
} version of RNTester Android with the new Architecture enabled`,
);
exec(
`./gradlew :packages:rn-tester:android:app:${
Expand Down

0 comments on commit 6552d47

Please sign in to comment.