Skip to content

Commit

Permalink
Comments only. Clarify a few Venice and SVC methods
Browse files Browse the repository at this point in the history
Summary: Changelog: [Internal]

Reviewed By: fkgozali

Differential Revision: D33468276

fbshipit-source-id: bcc62ba1e728bba2492dbbbb0e4569285effeca7
  • Loading branch information
p-sun authored and facebook-github-bot committed Jan 8, 2022
1 parent 9daae5a commit 6be46b0
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 0 deletions.
1 change: 1 addition & 0 deletions Libraries/NativeComponent/NativeComponentRegistry.js
Original file line number Diff line number Diff line change
Expand Up @@ -116,6 +116,7 @@ export function getWithFallback_DEPRECATED<Config>(
viewConfigProvider: () => PartialViewConfig,
): React.AbstractComponent<Config> {
if (getRuntimeConfig == null) {
// `getRuntimeConfig == null` when static view configs are disabled
// If `setRuntimeConfigProvider` is not configured, use native reflection.
if (hasNativeViewConfig(name)) {
return get<Config>(name, viewConfigProvider);
Expand Down
1 change: 1 addition & 0 deletions React/Fabric/Mounting/RCTComponentViewFactory.mm
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,7 @@

using namespace facebook::react;

// Allow JS runtime to register native components as needed. For static view configs.
void RCTInstallNativeComponentRegistryBinding(facebook::jsi::Runtime &runtime)
{
auto hasComponentProvider = [](std::string const &name) -> bool {
Expand Down

0 comments on commit 6be46b0

Please sign in to comment.