Check return code from malloc (#20173)

Summary:
Calls abort() in cases where malloc returns NULL.

Checking the return value from malloc is good practice and is
required to pass a [Veracode security scan](https://www.veracode.com/). This will let
developers who are required to submit their software to Veracode
use React Native.
Pull Request resolved: #20173

Differential Revision: D9235096

Pulled By: hramos

fbshipit-source-id: 9fdc97f9e84f8d4d91ae59242093907f7a81d286

Libraries/Image/RCTImageBlurUtils.m

@@ -35,6 +35,12 @@
  size_t bytes = buffer1.rowBytes * buffer1.height;
  buffer1.data = malloc(bytes);
  buffer2.data = malloc(bytes);
+ if (!buffer1.data || !buffer2.data) {
+ // CWE - 391 : Unchecked error condition
+ // https://www.cvedetails.com/cwe-details/391/Unchecked-Error-Condition.html
+ // https://eli.thegreenplace.net/2009/10/30/handling-out-of-memory-conditions-in-c
+ abort();
+ }
 
  // A description of how to compute the box kernel width from the Gaussian
  // radius (aka standard deviation) appears in the SVG spec:
@@ -45,6 +51,12 @@
  //create temp buffer
  void *tempBuffer = malloc((size_t)vImageBoxConvolve_ARGB8888(&buffer1, &buffer2, NULL, 0, 0, boxSize, boxSize,
  NULL, kvImageEdgeExtend + kvImageGetTempBufferSize));
+ if (!tempBuffer) {
+ // CWE - 391 : Unchecked error condition
+ // https://www.cvedetails.com/cwe-details/391/Unchecked-Error-Condition.html
+ // https://eli.thegreenplace.net/2009/10/30/handling-out-of-memory-conditions-in-c
+ abort();
+ }
 
  //copy image data
  CFDataRef dataSource = CGDataProviderCopyData(CGImageGetDataProvider(imageRef));

Libraries/Network/RCTNetworking.mm

@@ -50,6 +50,12 @@ @implementation RCTHTTPFormDataHelper
  const char *boundaryChars = "abcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ0123456789-_.";
 
  char *bytes = (char*)malloc(boundaryLength);
+ if (!bytes) {
+ // CWE - 391 : Unchecked error condition
+ // https://www.cvedetails.com/cwe-details/391/Unchecked-Error-Condition.html
+ // https://eli.thegreenplace.net/2009/10/30/handling-out-of-memory-conditions-in-c
+ abort();
+ }
  size_t charCount = strlen(boundaryChars);
  for (int i = 0; i < boundaryLength; i++) {
  bytes[i] = boundaryChars[arc4random_uniform((u_int32_t)charCount)];

React/Base/RCTModuleMethod.mm

@@ -302,6 +302,12 @@ - (void)processMethodSignature
 
  [argumentBlocks addObject:^(__unused RCTBridge *bridge, NSUInteger index, id json) {
  void *returnValue = malloc(typeSignature.methodReturnLength);
+ if (!returnValue) {
+ // CWE - 391 : Unchecked error condition
+ // https://www.cvedetails.com/cwe-details/391/Unchecked-Error-Condition.html
+ // https://eli.thegreenplace.net/2009/10/30/handling-out-of-memory-conditions-in-c
+ abort();
+ }
  [typeInvocation setArgument:&json atIndex:2];
  [typeInvocation invoke];
  [typeInvocation getReturnValue:returnValue];

React/Profiler/RCTProfile.m

@@ -76,14 +76,16 @@
  }
 
  systrace_arg_t *systrace_args = malloc(sizeof(systrace_arg_t) * args.count);
- __block size_t i = 0;
- [args enumerateKeysAndObjectsUsingBlock:^(NSString *key, NSString *value, __unused BOOL *stop) {
- systrace_args[i].key = [key UTF8String];
- systrace_args[i].key_len = [key length];
- systrace_args[i].value = [value UTF8String];
- systrace_args[i].value_len = [value length];
- i++;
- }];
+ if (systrace_args) {
+ __block size_t i = 0;
+ [args enumerateKeysAndObjectsUsingBlock:^(NSString *key, NSString *value, __unused BOOL *stop) {
+ systrace_args[i].key = [key UTF8String];
+ systrace_args[i].key_len = [key length];
+ systrace_args[i].value = [value UTF8String];
+ systrace_args[i].value_len = [value length];
+ i++;
+ }];
+ }
  return systrace_args;
 }
 

React/Views/RCTComponentData.m

@@ -167,6 +167,12 @@ static RCTPropBlock createNSInvocationSetter(NSMethodSignature *typeSignature, S
  if (json) {
  freeValueOnCompletion = YES;
  value = malloc(typeSignature.methodReturnLength);
+ if (!value) {
+ // CWE - 391 : Unchecked error condition
+ // https://www.cvedetails.com/cwe-details/391/Unchecked-Error-Condition.html
+ // https://eli.thegreenplace.net/2009/10/30/handling-out-of-memory-conditions-in-c
+ abort();
+ }
  [typeInvocation setArgument:&json atIndex:2];
  [typeInvocation invoke];
  [typeInvocation getReturnValue:value];