Skip to content

Commit

Permalink
LogBox - Double sync rendering timeout
Browse files Browse the repository at this point in the history
Summary:
On slower devices , 0.5s is not fast enough and we frequently render a black screen. Let's bump the sync rendering timeout to 1s.

Changelog: [Internal]

Reviewed By: sammy-SC

Differential Revision: D19282619

fbshipit-source-id: 0d9ae60f4869b0de7c4523c2cb33fbbf320c6438
  • Loading branch information
rickhanlonii authored and facebook-github-bot committed Jan 5, 2020
1 parent 173e783 commit 8881376
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions React/CoreModules/RCTLogBox.mm
Original file line number Diff line number Diff line change
Expand Up @@ -48,8 +48,8 @@ - (instancetype)initWithFrame:(CGRect)frame bridge:(RCTBridge *)bridge
[_surface start];
[_surface setSize:frame.size];

if (![_surface synchronouslyWaitForStage:RCTSurfaceStageSurfaceDidInitialMounting timeout:.5]) {
RCTLogInfo(@"Failed to mount LogBox within 500ms");
if (![_surface synchronouslyWaitForStage:RCTSurfaceStageSurfaceDidInitialMounting timeout:1]) {
RCTLogInfo(@"Failed to mount LogBox within 1s");
}

_rootViewController = [UIViewController new];
Expand Down

0 comments on commit 8881376

Please sign in to comment.