Skip to content

Commit

Permalink
Fix LogBoxSymbolication-test.js
Browse files Browse the repository at this point in the history
Summary:
This test was causing uncaught promise rejections, because the mocked `symbolicateStackTrace` in this test returns a different type from the real one, causing `LogBoxSymbolication`'s unawaited, cached promises to reject.

This wasn't picked up as a test failure because our `promise` polyfill silently swallows uncaught rejections, but it does cause a failure if we use native promises in tests.

Changelog:
[Internal][Fixed] - Fix LogBoxSymbolication-test.js

Reviewed By: huntie

Differential Revision: D39418412

fbshipit-source-id: 0be8f1551c4a58dc47faf1597caf47271af40af2
  • Loading branch information
robhogan authored and facebook-github-bot committed Sep 12, 2022
1 parent f1c1f81 commit 8e0168f
Showing 1 changed file with 6 additions and 2 deletions.
8 changes: 6 additions & 2 deletions Libraries/LogBox/Data/__tests__/LogBoxSymbolication-test.js
Original file line number Diff line number Diff line change
Expand Up @@ -12,14 +12,15 @@
'use strict';

import type {StackFrame} from '../../../Core/NativeExceptionsManager';
import type {SymbolicatedStackTrace} from '../../../Core/Devtools/symbolicateStackTrace';

jest.mock('../../../Core/Devtools/symbolicateStackTrace');

const LogBoxSymbolication = require('../LogBoxSymbolication');

const symbolicateStackTrace: JestMockFn<
$ReadOnlyArray<Array<StackFrame>>,
Promise<Array<StackFrame>>,
Promise<SymbolicatedStackTrace>,
> = (require('../../../Core/Devtools/symbolicateStackTrace'): any);

const createStack = (methodNames: Array<string>) =>
Expand All @@ -33,7 +34,10 @@ const createStack = (methodNames: Array<string>) =>
describe('LogBoxSymbolication', () => {
beforeEach(() => {
jest.resetModules();
symbolicateStackTrace.mockImplementation(async stack => stack);
symbolicateStackTrace.mockImplementation(async stack => ({
stack,
codeFrame: null,
}));
});

it('symbolicates different stacks', () => {
Expand Down

0 comments on commit 8e0168f

Please sign in to comment.