Skip to content

Commit

Permalink
Add jsinspector prefab target (#35796)
Browse files Browse the repository at this point in the history
Summary:
react-native-v8 requires the `jsinspector` for its js inspector feature. this pr adds the `jsinspector` to the prefab target list.

## Changelog

[ANDROID][ADDED] - Add `jsinspector` to the prefab target

Pull Request resolved: #35796

Test Plan:
```
$ ./gradlew :ReactAndroid:installArchives

# check prefab files in aar

$ unzip -l android/com/facebook/react/react-android/1000.0.0/react-android-1000.0.0-release.aar | grep 'prefab\/modules\/jsinspector'
$ unzip -l android/com/facebook/react/react-android/1000.0.0/react-android-1000.0.0-debug.aar | grep 'prefab\/modules\/jsinspector'
```

Reviewed By: cipolleschi

Differential Revision: D42430272

Pulled By: cortinico

fbshipit-source-id: fd9a02fd9c33cf5d349e1a79da6f78267196efc8
  • Loading branch information
Kudo authored and facebook-github-bot committed Jan 10, 2023
1 parent 88a1b8e commit a80cf96
Showing 1 changed file with 9 additions and 1 deletion.
10 changes: 9 additions & 1 deletion ReactAndroid/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -215,6 +215,10 @@ final def preparePrefab = tasks.register("preparePrefab", PreparePrefabHeadersTa
new Pair("../ReactCommon/cxxreact/", "cxxreact/"),
]
),
new PrefabPreprocessingEntry(
"jsinspector",
new Pair("../ReactCommon/jsinspector/", "jsinspector/"),
),
]
)
it.outputDir.set(prefabHeadersDir)
Expand Down Expand Up @@ -472,7 +476,8 @@ android {
"react_render_scheduler",
"react_render_mounting",
"hermes_executor",
"jscexecutor"
"jscexecutor",
"jsinspector"
}
}
ndk {
Expand Down Expand Up @@ -598,6 +603,9 @@ android {
jscexecutor {
headers(new File(prefabHeadersDir, "jscexecutor").absolutePath)
}
jsinspector {
headers(new File(prefabHeadersDir, "jsinspector").absolutePath)
}
}

publishing {
Expand Down

0 comments on commit a80cf96

Please sign in to comment.