Skip to content

Commit

Permalink
trivial: display target name in CocoaPods output
Browse files Browse the repository at this point in the history
Summary:
Without this, the CocoaPods output would display multiple "Building RNTester..." logs. With these changes, we make it clear that these are separate targets that are being configured.

Changelog: [internal]

Reviewed By: mdvacca, cipolleschi

Differential Revision: D40656813

fbshipit-source-id: a317112e804d08b9e64e2d62e8b27e4045b317b0
  • Loading branch information
hramos authored and facebook-github-bot committed Oct 25, 2022
1 parent 02e4fcd commit adaa4fe
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 7 deletions.
10 changes: 5 additions & 5 deletions packages/rn-tester/Podfile
Original file line number Diff line number Diff line change
Expand Up @@ -15,15 +15,15 @@ if USE_FRAMEWORKS
use_frameworks!
end

def pods(options = {}, use_flipper: !IN_CI && !USE_FRAMEWORKS)
def pods(target_name, options = {}, use_flipper: !IN_CI && !USE_FRAMEWORKS)
project 'RNTesterPods.xcodeproj'

fabric_enabled = true

# Hermes is now enabled by default.
# The following line will only disable Hermes if the USE_HERMES envvar is SET to a value other than 1 (e.g. USE_HERMES=0).
hermes_enabled = !ENV.has_key?('USE_HERMES') || ENV['USE_HERMES'] == '1'
puts "Building RNTester with Fabric #{fabric_enabled ? "enabled" : "disabled"}.#{hermes_enabled ? " Using Hermes engine." : ""}"
puts "Configuring #{target_name} with Fabric #{fabric_enabled ? "enabled" : "disabled"}.#{hermes_enabled ? " Using Hermes engine." : ""}"

if ENV['RCT_NEW_ARCH_ENABLED'] == '1'
# Custom fabric component is only supported when using codegen discovery.
Expand Down Expand Up @@ -51,16 +51,16 @@ def pods(options = {}, use_flipper: !IN_CI && !USE_FRAMEWORKS)
end

target 'RNTester' do
pods()
pods('RNTester')
end

target 'RNTesterUnitTests' do
pods()
pods('RNTesterUnitTests')
pod 'React-RCTTest', :path => "./RCTTest"
end

target 'RNTesterIntegrationTests' do
pods()
pods('RNTesterIntegrationTests')
pod 'React-RCTTest', :path => "./RCTTest"
end

Expand Down
4 changes: 2 additions & 2 deletions packages/rn-tester/Podfile.lock
Original file line number Diff line number Diff line change
Expand Up @@ -945,7 +945,7 @@ SPEC CHECKSUMS:
FlipperKit: cbdee19bdd4e7f05472a66ce290f1b729ba3cb86
fmt: ff9d55029c625d3757ed641535fd4a75fedc7ce9
glog: 04b94705f318337d7ead9e6d17c019bd9b1f6b1b
hermes-engine: 2c30267d0c2771edc2d369ac694d45f1278ab08b
hermes-engine: 05624e18294fd8279bb718e95d5bf2be311667ec
libevent: 4049cae6c81cdb3654a443be001fb9bdceff7913
OpenSSL-Universal: ebc357f1e6bc71fa463ccb2fe676756aff50e88c
RCT-Folly: 0080d0a6ebf2577475bda044aa59e2ca1f909cda
Expand Down Expand Up @@ -988,6 +988,6 @@ SPEC CHECKSUMS:
Yoga: 1b1a12ff3d86a10565ea7cbe057d42f5e5fb2a07
YogaKit: f782866e155069a2cca2517aafea43200b01fd5a

PODFILE CHECKSUM: e86c02825ce4e267e6fb3975bae791feb32a94a0
PODFILE CHECKSUM: 20298ecd3f30aa788ad491637e593ed0d8c100ca

COCOAPODS: 1.11.3

0 comments on commit adaa4fe

Please sign in to comment.