Skip to content

Commit

Permalink
Making UITemplateProcessorTest not instrumentation
Browse files Browse the repository at this point in the history
Summary: Instrumentation tests are expensive and flaky. Luckly this one does not need to be instrumentation one.

Reviewed By: mdvacca

Differential Revision: D15158985

fbshipit-source-id: 3c88e5a0d82db2cd00f5866c3f9956409cc8fc7f
  • Loading branch information
shergin authored and facebook-github-bot committed May 1, 2019
1 parent 45e77c8 commit b273516
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 12 deletions.
2 changes: 0 additions & 2 deletions ReactCommon/fabric/uimanager/BUCK
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,6 @@ fb_xplat_cxx_test(
"-Wall",
],
contacts = ["oncall+react_native@xmail.facebook.com"],
fbandroid_use_instrumentation_test = True,
platforms = (ANDROID, APPLE),
deps = [
"fbsource//xplat/folly:molly",
Expand All @@ -87,7 +86,6 @@ fb_xplat_cxx_test(
react_native_xplat_target("fabric/components/image:image"),
react_native_xplat_target("fabric/components/root:root"),
react_native_xplat_target("fabric/components/scrollview:scrollview"),
react_native_xplat_target("fabric/components/text:text"),
react_native_xplat_target("fabric/components/view:view"),
"fbsource//xplat/js/react-native-github:generated_components-rncore",
],
Expand Down
10 changes: 0 additions & 10 deletions ReactCommon/fabric/uimanager/tests/UITemplateProcessorTest.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -17,9 +17,6 @@ using namespace facebook::react;
#include <react/components/image/ImageComponentDescriptor.h>
#include <react/components/rncore/ComponentDescriptors.h>
#include <react/components/scrollview/ScrollViewComponentDescriptor.h>
#include <react/components/text/ParagraphComponentDescriptor.h>
#include <react/components/text/RawTextComponentDescriptor.h>
#include <react/components/text/TextComponentDescriptor.h>
#include <react/components/view/ViewComponentDescriptor.h>
#include <react/config/ReactNativeConfig.h>
#include <react/uimanager/ComponentDescriptorFactory.h>
Expand All @@ -41,13 +38,6 @@ ComponentRegistryFactory getDefaultComponentRegistryFactory() {
eventDispatcher, contextContainer));
registry->registerComponentDescriptor(
std::make_shared<ScrollViewComponentDescriptor>(eventDispatcher));
registry->registerComponentDescriptor(
std::make_shared<ParagraphComponentDescriptor>(
eventDispatcher, contextContainer));
registry->registerComponentDescriptor(
std::make_shared<TextComponentDescriptor>(eventDispatcher));
registry->registerComponentDescriptor(
std::make_shared<RawTextComponentDescriptor>(eventDispatcher));
registry->registerComponentDescriptor(
std::make_shared<ActivityIndicatorViewComponentDescriptor>(
eventDispatcher));
Expand Down

0 comments on commit b273516

Please sign in to comment.