Expose webSocketDidOpen in RCTReconnectingWebSocket

Summary: Expose webSocketDidOpen in RCTReconnectingWebSocket in order to get notified when the reconnecting websocket is opened to the endpoint. Reviewed By: emilsjolander Differential Revision: D5725547 fbshipit-source-id: e904c5a84d670ecf936993ec1739614f99fce09c
facebook · Aug 29, 2017 · bf67345 · bf67345
1 parent b11656a
commit bf67345
Show file tree

Hide file tree

Showing 4 changed files with 15 additions and 0 deletions.
diff --git a/Libraries/WebSocket/RCTReconnectingWebSocket.h b/Libraries/WebSocket/RCTReconnectingWebSocket.h
@@ -15,6 +15,8 @@
 
 @protocol RCTWebSocketProtocolDelegate
 
+- (void)webSocketDidOpen:(RCTSRWebSocket *)webSocket;
+
 - (void)webSocket:(RCTSRWebSocket *)webSocket didReceiveMessage:(id)message;
 
 - (void)webSocket:(RCTSRWebSocket *)webSocket didCloseWithCode:(NSInteger)code reason:(NSString *)reason wasClean:(BOOL)wasClean;

diff --git a/Libraries/WebSocket/RCTReconnectingWebSocket.m b/Libraries/WebSocket/RCTReconnectingWebSocket.m
@@ -101,6 +101,11 @@ - (void)reconnect
   });
 }
 
+- (void)webSocketDidOpen:(RCTSRWebSocket *)webSocket
+{
+  [self.delegate webSocketDidOpen:webSocket];
+}
+
 - (void)webSocket:(RCTSRWebSocket *)webSocket didFailWithError:(NSError *)error
 {
   [self reconnect];

diff --git a/Libraries/WebSocket/RCTWebSocketObserver.m b/Libraries/WebSocket/RCTWebSocketObserver.m
@@ -66,6 +66,10 @@ - (void)webSocket:(RCTSRWebSocket *)webSocket didReceiveMessage:(id)message
   }
 }
 
+- (void)webSocketDidOpen:(RCTSRWebSocket *)webSocket
+{
+}
+
 - (void)webSocket:(RCTSRWebSocket *)webSocket didCloseWithCode:(NSInteger)code reason:(NSString *)reason wasClean:(BOOL)wasClean
 {
 }

diff --git a/React/DevSupport/RCTPackagerConnection.m b/React/DevSupport/RCTPackagerConnection.m
@@ -132,6 +132,10 @@ - (void)webSocket:(RCTSRWebSocket *)webSocket didReceiveMessage:(id)message
   }
 }
 
+- (void)webSocketDidOpen:(RCTSRWebSocket *)webSocket
+{
+}
+
 - (void)webSocket:(RCTSRWebSocket *)webSocket didCloseWithCode:(NSInteger)code reason:(NSString *)reason wasClean:(BOOL)wasClean
 {
 }
-Original file line number
+Diff line change
@@ Expand Up @@
       }
     }
+    - (void)webSocketDidOpen:(RCTSRWebSocket *)webSocket
+    {
+    }
     - (void)webSocket:(RCTSRWebSocket *)webSocket didCloseWithCode:(NSInteger)code reason:(NSString *)reason wasClean:(BOOL)wasClean
     {
     }
@@ Expand Down @@